Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: updated footer.tsx file to update the year dynamically #1040

Merged
merged 2 commits into from
Mar 22, 2023
Merged

fix: updated footer.tsx file to update the year dynamically #1040

merged 2 commits into from
Mar 22, 2023

Conversation

mukulpadwal
Copy link
Contributor

@mukulpadwal mukulpadwal commented Mar 22, 2023

What type of PR is this? (check all applicable)

  • πŸ• Feature
  • πŸ› Bug Fix
  • πŸ“ Documentation Update
  • 🎨 Style
  • πŸ§‘β€πŸ’» Code Refactor
  • πŸ”₯ Performance Improvements
  • βœ… Test
  • πŸ€– Build
  • πŸ” CI
  • πŸ“¦ Chore (Release)
  • ⏩ Revert

Description

In the footer file the copyright year was hard coded as static and it was displaying 2022. I have updated it so it will be updated dynamically always.

Related Tickets & Documents

fixes #1041

Mobile & Desktop Screenshots/Recordings

Before:
Screenshot 2023-03-22 223519

After:
Screenshot 2023-03-22 225019

Added tests?

  • πŸ‘ yes
  • πŸ™… no, because they aren't needed
  • πŸ™‹ no, because I need help

Added to documentation?

  • πŸ“œ README.md
  • πŸ““ docs.opensauced.pizza
  • πŸ• dev.to/opensauced
  • πŸ“• storybook
  • πŸ™… no documentation needed

[optional] Are there any post-deployment tasks we need to perform?

[optional] What gif best describes this PR or how it makes you feel?

@netlify
Copy link

netlify bot commented Mar 22, 2023

βœ… Deploy Preview for design-insights ready!

Name Link
πŸ”¨ Latest commit 711299a
πŸ” Latest deploy log https://app.netlify.com/sites/design-insights/deploys/641b4438ca4ad1000821f9f5
😎 Deploy Preview https://deploy-preview-1040--design-insights.netlify.app
πŸ“± Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@netlify
Copy link

netlify bot commented Mar 22, 2023

βœ… Deploy Preview for oss-insights ready!

Built without sensitive environment variables

Name Link
πŸ”¨ Latest commit 711299a
πŸ” Latest deploy log https://app.netlify.com/sites/oss-insights/deploys/641b4438f1e2190008623205
😎 Deploy Preview https://deploy-preview-1040--oss-insights.netlify.app
πŸ“± Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Compliance Checks

Thank you for your Pull Request! We have run several checks on this pull request in order to make sure it's suitable for merging into this project. The results are listed in the following section.

Watched Files

This pull request modifies specific files that require careful review by the maintainers.

Files Matched

  • package.json

@mukulpadwal mukulpadwal changed the title Updated the footer file to update the year dynamically fix : updated 'footer.tsx file' to update the year dynamically Mar 22, 2023
@OgDev-01 OgDev-01 changed the title fix : updated 'footer.tsx file' to update the year dynamically fix: updated 'footer.tsx file' to update the year dynamically Mar 22, 2023
@mukulpadwal mukulpadwal changed the title fix: updated 'footer.tsx file' to update the year dynamically fix: updated footer.tsx file to update the year dynamically Mar 22, 2023
Copy link
Contributor

@OgDev-01 OgDev-01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this great contribution ! πŸ•

@OgDev-01 OgDev-01 added the needs review PRs that need review from core engineering team label Mar 22, 2023
@brandonroberts brandonroberts merged commit c766d95 into open-sauced:beta Mar 22, 2023
github-actions bot pushed a commit that referenced this pull request Mar 22, 2023
## [1.37.0-beta.4](v1.37.0-beta.3...v1.37.0-beta.4) (2023-03-22)

### πŸ› Bug Fixes

*  updated footer file to update the year dynamically ([#1040](#1040)) ([c766d95](c766d95))
@github-actions
Copy link
Contributor

πŸŽ‰ This PR is included in version 1.37.0-beta.4 πŸŽ‰

The release is available on GitHub release

Your semantic-release bot πŸ“¦πŸš€

github-actions bot pushed a commit that referenced this pull request Mar 24, 2023
## [1.37.0](v1.36.0...v1.37.0) (2023-03-24)

### πŸ§‘β€πŸ’» Code Refactoring

* Deleted unused hooks, removed unused exports and imports ([#1028](#1028)) ([7b2bda2](7b2bda2))

### πŸ• Features

* add teams UI for the design system ([#994](#994)) ([499d08e](499d08e))
* added active styles to navbar links ([#1016](#1016)) ([c25c0a3](c25c0a3)), closes [#697](#697)
* create collaboration Ui components ([#1006](#1006)) ([19ff5a7](19ff5a7))
* replace react toast to radix ([#933](#933)) ([3e000be](3e000be))
* update top nav menu to be more responsive on mobile ([#1029](#1029)) ([90c1e4a](90c1e4a)), closes [#866](#866)

### πŸ› Bug Fixes

*  updated footer file to update the year dynamically ([#1040](#1040)) ([c766d95](c766d95))
* add a check for proper URL in avatarURL prop ([#1009](#1009)) ([a425279](a425279))
* center text inside upgrade access button ([#1027](#1027)) ([cf3f6cb](cf3f6cb)), closes [#1024](#1024)
* close highlight dialog when clicking outside its container ([#999](#999)) ([1bc90bb](1bc90bb))
* make delete standout ([#1026](#1026)) ([9c68287](9c68287))
* make insights hub layout inconsistent on larger screens ([#1046](#1046)) ([daaf6d1](daaf6d1))
* refresh highlights list on update and delete ([#1034](#1034)) ([bf2d951](bf2d951))
* remove dialog layout overlap on single highlight view ([#1047](#1047)) ([ea836e8](ea836e8))
* update avatar style to remain aligned with the input field ([#1037](#1037)) ([2374f20](2374f20))
ElpisHelle added a commit to ElpisHelle/next.js-tailwindcss that referenced this pull request Aug 17, 2023
## [1.37.0-beta.4](open-sauced/app@v1.37.0-beta.3...v1.37.0-beta.4) (2023-03-22)

### πŸ› Bug Fixes

*  updated footer file to update the year dynamically ([#1040](open-sauced/app#1040)) ([c766d95](open-sauced/app@c766d95))
ElpisHelle added a commit to ElpisHelle/next.js-tailwindcss that referenced this pull request Aug 17, 2023
## [1.37.0](open-sauced/app@v1.36.0...v1.37.0) (2023-03-24)

### πŸ§‘β€πŸ’» Code Refactoring

* Deleted unused hooks, removed unused exports and imports ([#1028](open-sauced/app#1028)) ([7b2bda2](open-sauced/app@7b2bda2))

### πŸ• Features

* add teams UI for the design system ([#994](open-sauced/app#994)) ([499d08e](open-sauced/app@499d08e))
* added active styles to navbar links ([#1016](open-sauced/app#1016)) ([c25c0a3](open-sauced/app@c25c0a3)), closes [#697](open-sauced/app#697)
* create collaboration Ui components ([#1006](open-sauced/app#1006)) ([19ff5a7](open-sauced/app@19ff5a7))
* replace react toast to radix ([#933](open-sauced/app#933)) ([3e000be](open-sauced/app@3e000be))
* update top nav menu to be more responsive on mobile ([#1029](open-sauced/app#1029)) ([90c1e4a](open-sauced/app@90c1e4a)), closes [#866](open-sauced/app#866)

### πŸ› Bug Fixes

*  updated footer file to update the year dynamically ([#1040](open-sauced/app#1040)) ([c766d95](open-sauced/app@c766d95))
* add a check for proper URL in avatarURL prop ([#1009](open-sauced/app#1009)) ([a425279](open-sauced/app@a425279))
* center text inside upgrade access button ([#1027](open-sauced/app#1027)) ([cf3f6cb](open-sauced/app@cf3f6cb)), closes [#1024](open-sauced/app#1024)
* close highlight dialog when clicking outside its container ([#999](open-sauced/app#999)) ([1bc90bb](open-sauced/app@1bc90bb))
* make delete standout ([#1026](open-sauced/app#1026)) ([9c68287](open-sauced/app@9c68287))
* make insights hub layout inconsistent on larger screens ([#1046](open-sauced/app#1046)) ([daaf6d1](open-sauced/app@daaf6d1))
* refresh highlights list on update and delete ([#1034](open-sauced/app#1034)) ([bf2d951](open-sauced/app@bf2d951))
* remove dialog layout overlap on single highlight view ([#1047](open-sauced/app#1047)) ([ea836e8](open-sauced/app@ea836e8))
* update avatar style to remain aligned with the input field ([#1037](open-sauced/app#1037)) ([2374f20](open-sauced/app@2374f20))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs review PRs that need review from core engineering team released on @beta
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Static footer Year Update
3 participants