fix: update local time option from user settings #951

OgDev-01 · 2023-03-05T17:23:40Z

What type of PR is this? (check all applicable)

Description

This PR updates display local time check option in user's settings to reflect previously saved value and also hide timezone ui when this option is false

Related Tickets & Documents

Fixes #946

Mobile & Desktop Screenshots/Recordings

Added tests?

👍 yes
🙅 no, because they aren't needed
🙋 no, because I need help

Added to documentation?

[optional] Are there any post-deployment tasks we need to perform?

[optional] What gif best describes this PR or how it makes you feel?

netlify · 2023-03-05T17:23:53Z

✅ Deploy Preview for oss-insights ready!

Name	Link
🔨 Latest commit	`32be3ad`
🔍 Latest deploy log	https://app.netlify.com/sites/oss-insights/deploys/640b440752bd840008d75780
😎 Deploy Preview	https://deploy-preview-951--oss-insights.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

netlify · 2023-03-05T17:23:53Z

✅ Deploy Preview for design-insights ready!

Name	Link
🔨 Latest commit	`32be3ad`
🔍 Latest deploy log	https://app.netlify.com/sites/design-insights/deploys/640b4407d8bccf000893a34c
😎 Deploy Preview	https://deploy-preview-951--design-insights.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

brandonroberts · 2023-03-06T14:13:25Z

@OgDev-01 @bdougie we are currently using this setting here

https://github.com/open-sauced/insights/blob/beta/components/molecules/ContributorProfileInfo/contributor-profile-info.tsx#L76

That needs to be updated also if we're no longer using this setting

bdougie · 2023-03-06T14:16:41Z

@OgDev-01 @bdougie we are currently using this setting here

If the setting is being used in the UI, it doesn't seem to be not working as intended. Can you confirm @OgDev-01. This was the report from Steven, we may have jumped to a conclusion to remove the feature rather than fix it.

As I read it now, he is stating the Timezone is still displayed but doesn't confirm if local time if not (the intended feature).

OgDev-01 · 2023-03-06T14:44:12Z

I just confirmed that the value is being used in the user profile. Just a minor issue with the checkbox because its default value is not populated from the user's data but a local state variable. So when a user updates their profile to show the date and reloads the page, the checkbox remains unchecked even if the settings have been updated

The displayLocalTime value in the above screenshot is derived from a local useState variable and I think that's what needs fixing

bdougie

We incorrectly interpreted this request from the user. We should remove timezone from the public profile in addition to local time when this is selected.

Leave the setting available.

OgDev-01 · 2023-03-10T14:47:12Z

Option added back and now reflects users previously saved value by defauilt

brandonroberts

LGTM

0-vortex

Thought this switch in the user settings would change the display from "bdougie time is 09:00" to "bdougie is -10 hrs behind", otherwise LGTM! 👍

## [1.34.0-beta.9](v1.34.0-beta.8...v1.34.0-beta.9) (2023-03-10) ### 🐛 Bug Fixes * update local time option from user settings ([#951](#951)) ([c91a513](c91a513))

github-actions · 2023-03-10T17:14:11Z

🎉 This PR is included in version 1.34.0-beta.9 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

## [1.34.0](v1.33.0...v1.34.0) (2023-03-10) ### 🍕 Features * add custom tooltip to pr list icon ([#962](#962)) ([44fa050](44fa050)), closes [#955](#955) * add delete highlight implementation ([#963](#963)) ([10575f1](10575f1)), closes [#906](#906) * implement highlight's permanent link ([#957](#957)) ([78ad176](78ad176)), closes [#895](#895) [#950](#950) * remove the repo click to filter feature & link to github ([#989](#989)) ([6f62b46](6f62b46)), closes [#983](#983) ### 🧑‍💻 Code Refactoring * add invalid pull url feedback ([#992](#992)) ([28fe15c](28fe15c)), closes [#961](#961) ### 🐛 Bug Fixes * add Rust to interests options and combine utility function ([#977](#977)) ([28a5270](28a5270)), closes [#976](#976) * add skeleton wrapper atom to storybook ([#990](#990)) ([780d345](780d345)) * adds more placeholder ([#971](#971)) ([bf5daa7](bf5daa7)) * adjust input body overlap when editing a highlight ([#991](#991)) ([1512f7d](1512f7d)) * fix pointer-events when closing edit dialog ([#987](#987)) ([df6eb2b](df6eb2b)) * update local time option from user settings ([#951](#951)) ([c91a513](c91a513))

## [1.34.0-beta.9](open-sauced/app@v1.34.0-beta.8...v1.34.0-beta.9) (2023-03-10) ### 🐛 Bug Fixes * update local time option from user settings ([#951](open-sauced/app#951)) ([c91a513](open-sauced/app@c91a513))

## [1.34.0](open-sauced/app@v1.33.0...v1.34.0) (2023-03-10) ### 🍕 Features * add custom tooltip to pr list icon ([#962](open-sauced/app#962)) ([44fa050](open-sauced/app@44fa050)), closes [#955](open-sauced/app#955) * add delete highlight implementation ([#963](open-sauced/app#963)) ([10575f1](open-sauced/app@10575f1)), closes [#906](open-sauced/app#906) * implement highlight's permanent link ([#957](open-sauced/app#957)) ([78ad176](open-sauced/app@78ad176)), closes [#895](open-sauced/app#895) [#950](open-sauced/app#950) * remove the repo click to filter feature & link to github ([#989](open-sauced/app#989)) ([6f62b46](open-sauced/app@6f62b46)), closes [#983](open-sauced/app#983) ### 🧑‍💻 Code Refactoring * add invalid pull url feedback ([#992](open-sauced/app#992)) ([28fe15c](open-sauced/app@28fe15c)), closes [#961](open-sauced/app#961) ### 🐛 Bug Fixes * add Rust to interests options and combine utility function ([#977](open-sauced/app#977)) ([28a5270](open-sauced/app@28a5270)), closes [#976](open-sauced/app#976) * add skeleton wrapper atom to storybook ([#990](open-sauced/app#990)) ([780d345](open-sauced/app@780d345)) * adds more placeholder ([#971](open-sauced/app#971)) ([bf5daa7](open-sauced/app@bf5daa7)) * adjust input body overlap when editing a highlight ([#991](open-sauced/app#991)) ([1512f7d](open-sauced/app@1512f7d)) * fix pointer-events when closing edit dialog ([#987](open-sauced/app#987)) ([df6eb2b](open-sauced/app@df6eb2b)) * update local time option from user settings ([#951](open-sauced/app#951)) ([c91a513](open-sauced/app@c91a513))

OgDev-01 added 2 commits March 5, 2023 18:19

fix: remove local time option from settings

4979d0a

refactor: remove irrelevant comments

da91ae2

bdougie approved these changes Mar 5, 2023

View reviewed changes

bdougie requested changes Mar 7, 2023

View reviewed changes

bdougie added the requested changes label Mar 7, 2023

fix: display time refactor

a154ffe

OgDev-01 and others added 2 commits March 10, 2023 15:48

Merge branch 'beta' into 946-remove-local-time

e88cb48

fix: build error

32be3ad

OgDev-01 requested a review from bdougie March 10, 2023 14:55

OgDev-01 changed the title ~~fix: remove local time option from user settings~~ fix: update local time option from user settings Mar 10, 2023

OgDev-01 requested review from brandonroberts, nightknighto and 0-vortex March 10, 2023 14:58

OgDev-01 added needs review PRs that need review from core engineering team and removed requested changes labels Mar 10, 2023

brandonroberts approved these changes Mar 10, 2023

View reviewed changes

brandonroberts added needs-approval and removed needs review PRs that need review from core engineering team labels Mar 10, 2023

0-vortex approved these changes Mar 10, 2023

View reviewed changes

nightknighto approved these changes Mar 10, 2023

View reviewed changes

brandonroberts merged commit c91a513 into beta Mar 10, 2023

brandonroberts deleted the 946-remove-local-time branch March 10, 2023 17:09

github-actions bot added the released on @beta label Mar 10, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix: update local time option from user settings #951

fix: update local time option from user settings #951

OgDev-01 commented Mar 5, 2023 •

edited

Loading

netlify bot commented Mar 5, 2023 •

edited

Loading

netlify bot commented Mar 5, 2023 •

edited

Loading

brandonroberts commented Mar 6, 2023

bdougie commented Mar 6, 2023 •

edited

Loading

OgDev-01 commented Mar 6, 2023 •

edited

Loading

bdougie left a comment

OgDev-01 commented Mar 10, 2023

brandonroberts left a comment

0-vortex left a comment •

edited

Loading

github-actions bot commented Mar 10, 2023

fix: update local time option from user settings #951

fix: update local time option from user settings #951

Conversation

OgDev-01 commented Mar 5, 2023 • edited Loading

What type of PR is this? (check all applicable)

Description

Related Tickets & Documents

Mobile & Desktop Screenshots/Recordings

Added tests?

Added to documentation?

[optional] Are there any post-deployment tasks we need to perform?

[optional] What gif best describes this PR or how it makes you feel?

netlify bot commented Mar 5, 2023 • edited Loading

✅ Deploy Preview for oss-insights ready!

netlify bot commented Mar 5, 2023 • edited Loading

✅ Deploy Preview for design-insights ready!

brandonroberts commented Mar 6, 2023

bdougie commented Mar 6, 2023 • edited Loading

OgDev-01 commented Mar 6, 2023 • edited Loading

bdougie left a comment

Choose a reason for hiding this comment

OgDev-01 commented Mar 10, 2023

brandonroberts left a comment

Choose a reason for hiding this comment

0-vortex left a comment • edited Loading

Choose a reason for hiding this comment

github-actions bot commented Mar 10, 2023

OgDev-01 commented Mar 5, 2023 •

edited

Loading

netlify bot commented Mar 5, 2023 •

edited

Loading

netlify bot commented Mar 5, 2023 •

edited

Loading

bdougie commented Mar 6, 2023 •

edited

Loading

OgDev-01 commented Mar 6, 2023 •

edited

Loading

0-vortex left a comment •

edited

Loading