feat: Add delete highlights implementation #963

OgDev-01 · 2023-03-07T12:41:13Z

What type of PR is this? (check all applicable)

Description

This PR:

Adds delete button to delete a highlight
Adds alert dialog to prompt a user to confirm delete action or cancel

Related Tickets & Documents

Fixes #906

Mobile & Desktop Screenshots/Recordings

Added tests?

👍 yes
🙅 no, because they aren't needed
🙋 no, because I need help

Added to documentation?

[optional] Are there any post-deployment tasks we need to perform?

[optional] What gif best describes this PR or how it makes you feel?

netlify · 2023-03-07T12:41:18Z

✅ Deploy Preview for oss-insights ready!

Name	Link
🔨 Latest commit	`1f78d65`
🔍 Latest deploy log	https://app.netlify.com/sites/oss-insights/deploys/640b3ade7933f40008c4e110
😎 Deploy Preview	https://deploy-preview-963--oss-insights.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

netlify · 2023-03-07T12:41:19Z

✅ Deploy Preview for design-insights ready!

Name	Link
🔨 Latest commit	`1f78d65`
🔍 Latest deploy log	https://app.netlify.com/sites/design-insights/deploys/640b3adecb3f6900083b8861
😎 Deploy Preview	https://deploy-preview-963--design-insights.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

github-actions

PR Compliance Checks

Thank you for your Pull Request! We have run several checks on this pull request in order to make sure it's suitable for merging into this project. The results are listed in the following section.

Watched Files

This pull request modifies specific files that require careful review by the maintainers.

Files Matched

npm-shrinkwrap.json
package.json

brandonroberts

Functionally works. List is not refreshed, but may be covered in #957

bdougie

Missed this in the design review, but can we light the delete button to match what is on the inisights page. Link to Figma

cc @getaheaddev

update: on hover is not great. Should not be orange.

nightknighto

Just some little details

lib/hooks/useFetchUserHighlights.ts

lib/hooks/deleteHighlight.ts

lib/hooks/useFetchUserHighlights.ts

nightknighto · 2023-03-09T18:32:16Z

lib/hooks/deleteHighlight.ts

+      const error = new Error("HttpError");
+
+      error.message = `${res.status} ${res.statusText}`;
+      error.stack = JSON.stringify(await res.json());


Maybe we should start using axios to automatically throw errors on non-ok requests. Something for the future.

nightknighto

LGTM

brandonroberts · 2023-03-09T18:52:30Z

@OgDev-01 resolve merge conflicts and this is good to go

…06-delete-highlight

## [1.34.0-beta.6](v1.34.0-beta.5...v1.34.0-beta.6) (2023-03-10) ### 🍕 Features * add delete highlight implementation ([#963](#963)) ([10575f1](10575f1)), closes [#906](#906)

github-actions · 2023-03-10T14:23:57Z

🎉 This PR is included in version 1.34.0-beta.6 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

## [1.34.0](v1.33.0...v1.34.0) (2023-03-10) ### 🍕 Features * add custom tooltip to pr list icon ([#962](#962)) ([44fa050](44fa050)), closes [#955](#955) * add delete highlight implementation ([#963](#963)) ([10575f1](10575f1)), closes [#906](#906) * implement highlight's permanent link ([#957](#957)) ([78ad176](78ad176)), closes [#895](#895) [#950](#950) * remove the repo click to filter feature & link to github ([#989](#989)) ([6f62b46](6f62b46)), closes [#983](#983) ### 🧑‍💻 Code Refactoring * add invalid pull url feedback ([#992](#992)) ([28fe15c](28fe15c)), closes [#961](#961) ### 🐛 Bug Fixes * add Rust to interests options and combine utility function ([#977](#977)) ([28a5270](28a5270)), closes [#976](#976) * add skeleton wrapper atom to storybook ([#990](#990)) ([780d345](780d345)) * adds more placeholder ([#971](#971)) ([bf5daa7](bf5daa7)) * adjust input body overlap when editing a highlight ([#991](#991)) ([1512f7d](1512f7d)) * fix pointer-events when closing edit dialog ([#987](#987)) ([df6eb2b](df6eb2b)) * update local time option from user settings ([#951](#951)) ([c91a513](c91a513))

## [1.34.0-beta.6](open-sauced/app@v1.34.0-beta.5...v1.34.0-beta.6) (2023-03-10) ### 🍕 Features * add delete highlight implementation ([#963](open-sauced/app#963)) ([10575f1](open-sauced/app@10575f1)), closes [#906](open-sauced/app#906)

## [1.34.0](open-sauced/app@v1.33.0...v1.34.0) (2023-03-10) ### 🍕 Features * add custom tooltip to pr list icon ([#962](open-sauced/app#962)) ([44fa050](open-sauced/app@44fa050)), closes [#955](open-sauced/app#955) * add delete highlight implementation ([#963](open-sauced/app#963)) ([10575f1](open-sauced/app@10575f1)), closes [#906](open-sauced/app#906) * implement highlight's permanent link ([#957](open-sauced/app#957)) ([78ad176](open-sauced/app@78ad176)), closes [#895](open-sauced/app#895) [#950](open-sauced/app#950) * remove the repo click to filter feature & link to github ([#989](open-sauced/app#989)) ([6f62b46](open-sauced/app@6f62b46)), closes [#983](open-sauced/app#983) ### 🧑‍💻 Code Refactoring * add invalid pull url feedback ([#992](open-sauced/app#992)) ([28fe15c](open-sauced/app@28fe15c)), closes [#961](open-sauced/app#961) ### 🐛 Bug Fixes * add Rust to interests options and combine utility function ([#977](open-sauced/app#977)) ([28a5270](open-sauced/app@28a5270)), closes [#976](open-sauced/app#976) * add skeleton wrapper atom to storybook ([#990](open-sauced/app#990)) ([780d345](open-sauced/app@780d345)) * adds more placeholder ([#971](open-sauced/app#971)) ([bf5daa7](open-sauced/app@bf5daa7)) * adjust input body overlap when editing a highlight ([#991](open-sauced/app#991)) ([1512f7d](open-sauced/app@1512f7d)) * fix pointer-events when closing edit dialog ([#987](open-sauced/app#987)) ([df6eb2b](open-sauced/app@df6eb2b)) * update local time option from user settings ([#951](open-sauced/app#951)) ([c91a513](open-sauced/app@c91a513))

chore: initial commit

b07b52f

OgDev-01 marked this pull request as draft March 7, 2023 12:41

OgDev-01 added 2 commits March 8, 2023 08:20

feat: implement delete highlight

bf1ecaa

style: cleanup css styling for responsiveness

2f9506f

OgDev-01 marked this pull request as ready for review March 8, 2023 15:25

OgDev-01 requested review from brandonroberts, bdougie and nightknighto March 8, 2023 15:25

OgDev-01 added the needs review PRs that need review from core engineering team label Mar 8, 2023

github-actions bot reviewed Mar 8, 2023

View reviewed changes

brandonroberts approved these changes Mar 8, 2023

View reviewed changes

bdougie requested changes Mar 8, 2023

View reviewed changes

nightknighto suggested changes Mar 8, 2023

View reviewed changes

lib/hooks/useFetchUserHighlights.ts Outdated Show resolved Hide resolved

lib/hooks/deleteHighlight.ts Show resolved Hide resolved

bdougie added requested changes and removed needs review PRs that need review from core engineering team labels Mar 8, 2023

OgDev-01 added 3 commits March 8, 2023 23:05

chore: cleanups

147bf2d

refactor: update error handling

72c032a

styles: button style update

8f43e98

OgDev-01 requested review from nightknighto and bdougie March 9, 2023 13:40

OgDev-01 added needs review PRs that need review from core engineering team and removed requested changes labels Mar 9, 2023

brandonroberts reviewed Mar 9, 2023

View reviewed changes

lib/hooks/useFetchUserHighlights.ts Outdated Show resolved Hide resolved

fix: api call config

62e23eb

nightknighto reviewed Mar 9, 2023

View reviewed changes

nightknighto approved these changes Mar 9, 2023

View reviewed changes

Merge branch 'beta' of https://github.com/open-sauced/insights into 9…

2585e17

…06-delete-highlight

bdougie approved these changes Mar 9, 2023

View reviewed changes

bdougie added ready-to-merge and removed needs review PRs that need review from core engineering team labels Mar 10, 2023

Merge branch 'beta' into 906-delete-highlight

1f78d65

brandonroberts merged commit 10575f1 into beta Mar 10, 2023

brandonroberts deleted the 906-delete-highlight branch March 10, 2023 14:19

github-actions bot added the released on @beta label Mar 10, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: Add delete highlights implementation #963

feat: Add delete highlights implementation #963

OgDev-01 commented Mar 7, 2023 •

edited

Loading

netlify bot commented Mar 7, 2023 •

edited

Loading

netlify bot commented Mar 7, 2023 •

edited

Loading

github-actions bot left a comment

brandonroberts left a comment

bdougie left a comment •

edited

Loading

nightknighto left a comment

nightknighto Mar 9, 2023 •

edited

Loading

nightknighto left a comment

brandonroberts commented Mar 9, 2023

github-actions bot commented Mar 10, 2023

feat: Add delete highlights implementation #963

feat: Add delete highlights implementation #963

Conversation

OgDev-01 commented Mar 7, 2023 • edited Loading

What type of PR is this? (check all applicable)

Description

Related Tickets & Documents

Mobile & Desktop Screenshots/Recordings

Added tests?

Added to documentation?

[optional] Are there any post-deployment tasks we need to perform?

[optional] What gif best describes this PR or how it makes you feel?

netlify bot commented Mar 7, 2023 • edited Loading

✅ Deploy Preview for oss-insights ready!

netlify bot commented Mar 7, 2023 • edited Loading

✅ Deploy Preview for design-insights ready!

github-actions bot left a comment

Choose a reason for hiding this comment

PR Compliance Checks

Watched Files

brandonroberts left a comment

Choose a reason for hiding this comment

bdougie left a comment • edited Loading

Choose a reason for hiding this comment

nightknighto left a comment

Choose a reason for hiding this comment

nightknighto Mar 9, 2023 • edited Loading

Choose a reason for hiding this comment

nightknighto left a comment

Choose a reason for hiding this comment

brandonroberts commented Mar 9, 2023

github-actions bot commented Mar 10, 2023

OgDev-01 commented Mar 7, 2023 •

edited

Loading

netlify bot commented Mar 7, 2023 •

edited

Loading

netlify bot commented Mar 7, 2023 •

edited

Loading

bdougie left a comment •

edited

Loading

nightknighto Mar 9, 2023 •

edited

Loading