-
Notifications
You must be signed in to change notification settings - Fork 63
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Added new favicon #69
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PR Compliance Checks
Thank you for your Pull Request! We have run several checks on this pull request in order to make sure it's suitable for merging into this project. The results are listed in the following section.
Issue Reference
In order to be considered for merging, the pull request description must refer to a specific issue number. This is described in our Contributing Guide.
This check is looking for a phrase similar to: "Fixes #XYZ" or "Resolves #XYZ" where XYZ is the issue number that this PR is meant to address.
Please add a screenshot for visual changes too :) |
Hi @diivi, I am getting some errors while deploying to the browser after using
|
I have faced this error too, it's probably because of a version mismatch.
To remove this setting, to make sure |
Don't do that, that is opening up your machine to some SSL security concern. Instead, wait for #74 to get merged and update from the main branch! |
It's setting an env variable for the current shell session, I close the session right after. How is it a security issue then? |
The SSL libs require patching inside the package-lock, because we are not using the fixed nodejs version in our workflows, it's enabling the propagation of the bug to our deploys, and anyone cloning the project π |
What type of PR is this? (check all applicable)
Description
Related Tickets & Documents
Fixes: #65
Mobile & Desktop Screenshots/Recordings
Added tests?
Added to documentation?
[optional] Are there any post-deployment tasks we need to perform?
[optional] What gif best describes this PR or how it makes you feel?