Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Added new favicon #69

Closed
wants to merge 2 commits into from
Closed

feat: Added new favicon #69

wants to merge 2 commits into from

Conversation

rameshchandra8520
Copy link
Contributor

@rameshchandra8520 rameshchandra8520 commented Mar 24, 2023

What type of PR is this? (check all applicable)

  • πŸ• Feature
  • πŸ› Bug Fix
  • πŸ“ Documentation Update
  • 🎨 Style
  • πŸ§‘β€πŸ’» Code Refactor
  • πŸ”₯ Performance Improvements
  • βœ… Test
  • πŸ€– Build
  • πŸ” CI
  • πŸ“¦ Chore (Release)
  • ⏩ Revert

Description

Related Tickets & Documents

Fixes: #65

Mobile & Desktop Screenshots/Recordings

Added tests?

  • πŸ‘ yes
  • πŸ™… no, because they aren't needed
  • πŸ™‹ no, because I need help

Added to documentation?

  • πŸ“œ README.md
  • πŸ““ docs.opensauced.pizza
  • πŸ• dev.to/opensauced
  • πŸ“• storybook
  • πŸ™… no documentation needed

[optional] Are there any post-deployment tasks we need to perform?

[optional] What gif best describes this PR or how it makes you feel?

Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Compliance Checks

Thank you for your Pull Request! We have run several checks on this pull request in order to make sure it's suitable for merging into this project. The results are listed in the following section.

Issue Reference

In order to be considered for merging, the pull request description must refer to a specific issue number. This is described in our Contributing Guide.
This check is looking for a phrase similar to: "Fixes #XYZ" or "Resolves #XYZ" where XYZ is the issue number that this PR is meant to address.

@diivi
Copy link
Contributor

diivi commented Mar 24, 2023

Please add a screenshot for visual changes too :)

@rameshchandra8520
Copy link
Contributor Author

Hi @diivi, I am getting some errors while deploying to the browser after using npm start. Can you help me with where I am missing something?
(I followed the procedure mentioned in the Readme file)

Compiled with some errors in 1.37s

Error: error:0308010C:digital envelope routines::unsupported
    at String.replace (<anonymous>)
Error: error:0308010C:digital envelope routines::unsupported
    at String.replace (<anonymous>)
Error: error:0308010C:digital envelope routines::unsupported
    at String.replace (<anonymous>)
Error: error:0308010C:digital envelope routines::unsupported
    at String.replace (<anonymous>)
Error: error:0308010C:digital envelope routines::unsupported
    at String.replace (<anonymous>)
Error: error:0308010C:digital envelope routines::unsupported
    at String.replace (<anonymous>)
Error: error:0308010C:digital envelope routines::unsupported
    at String.replace (<anonymous>)
Error: error:0308010C:digital envelope routines::unsupported
    at String.replace (<anonymous>)
Error: error:0308010C:digital envelope routines::unsupported
    at String.replace (<anonymous>)
Error: error:0308010C:digital envelope routines::unsupported
    at String.replace (<anonymous>)
Error: error:0308010C:digital envelope routines::unsupported
    at String.replace (<anonymous>)
Error: error:0308010C:digital envelope routines::unsupported
    at String.replace (<anonymous>)
Error: error:0308010C:digital envelope routines::unsupported
    at String.replace (<anonymous>)
Error: error:0308010C:digital envelope routines::unsupported
    at String.replace (<anonymous>)
Error: error:0308010C:digital envelope routines::unsupported
    at String.replace (<anonymous>)
Error: error:0308010C:digital envelope routines::unsupported
    at String.replace (<anonymous>)
Error: error:0308010C:digital envelope routines::unsupported
    at String.replace (<anonymous>)
client (webpack 5.61.0) compiled with 18 errors

@diivi
Copy link
Contributor

diivi commented Mar 25, 2023

I have faced this error too, it's probably because of a version mismatch.
Type this in your terminal and run the tests again.

export NODE_OPTIONS=--openssl-legacy-provider

To remove this setting, to make sure git push and other commands work, just reopen the terminal.

@0-vortex
Copy link
Contributor

I have faced this error too, it's probably because of a version mismatch. Type this in your terminal and run the tests again.

export NODE_OPTIONS=--openssl-legacy-provider

To remove this setting, to make sure git push and other commands work, just reopen the terminal.

Don't do that, that is opening up your machine to some SSL security concern. Instead, wait for #74 to get merged and update from the main branch!

@rameshchandra8520 rameshchandra8520 closed this by deleting the head repository Mar 25, 2023
@diivi
Copy link
Contributor

diivi commented Mar 25, 2023

I have faced this error too, it's probably because of a version mismatch. Type this in your terminal and run the tests again.
export NODE_OPTIONS=--openssl-legacy-provider
To remove this setting, to make sure git push and other commands work, just reopen the terminal.

Don't do that, that is opening up your machine to some SSL security concern. Instead, wait for #74 to get merged and update from the main branch!

It's setting an env variable for the current shell session, I close the session right after. How is it a security issue then?

@0-vortex
Copy link
Contributor

I have faced this error too, it's probably because of a version mismatch. Type this in your terminal and run the tests again.
export NODE_OPTIONS=--openssl-legacy-provider
To remove this setting, to make sure git push and other commands work, just reopen the terminal.

Don't do that, that is opening up your machine to some SSL security concern. Instead, wait for #74 to get merged and update from the main branch!

It's setting an env variable for the current shell session, I close the session right after. How is it a security issue then?

The SSL libs require patching inside the package-lock, because we are not using the fixed nodejs version in our workflows, it's enabling the propagation of the bug to our deploys, and anyone cloning the project πŸ˜…

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature: Match the favicon from hot.opensauced.pizza
3 participants