Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: correct node 17 webpack security concerns and audit fix #74

Merged
merged 2 commits into from
Mar 25, 2023

Conversation

0-vortex
Copy link
Contributor

What type of PR is this? (check all applicable)

  • πŸ• Feature
  • πŸ› Bug Fix
  • πŸ“ Documentation Update
  • 🎨 Style
  • πŸ§‘β€πŸ’» Code Refactor
  • πŸ”₯ Performance Improvements
  • βœ… Test
  • πŸ€– Build
  • πŸ” CI
  • πŸ“¦ Chore (Release)
  • ⏩ Revert

Description

This PR corrects some of the issues new contributors faced while trying to run the project using node 17+

Related Tickets & Documents

Mobile & Desktop Screenshots/Recordings

Added tests?

  • πŸ‘ yes
  • πŸ™… no, because they aren't needed
  • πŸ™‹ no, because I need help

Added to documentation?

  • πŸ“œ README.md
  • πŸ““ docs.opensauced.pizza
  • πŸ• dev.to/opensauced
  • πŸ“• storybook
  • πŸ™… no documentation needed

[optional] Are there any post-deployment tasks we need to perform?

[optional] What gif best describes this PR or how it makes you feel?

@netlify
Copy link

netlify bot commented Mar 25, 2023

❌ Deploy Preview for docs-open failed.

Name Link
πŸ”¨ Latest commit ce1577b
πŸ” Latest deploy log https://app.netlify.com/sites/docs-open/deploys/641f5b3fb65691000807911b

@0-vortex 0-vortex mentioned this pull request Mar 25, 2023
19 tasks
@0-vortex
Copy link
Contributor Author

@bdougie Just a heads up it seems like it's configured for node 12 and the gh-pages static branch we have set up for release - unless set up by yourself, it looks like a huge security concern trying to overwrite the current static release but failing at the node version.

Will fast track this to unblock other developers, waiting on your input about netlify πŸ˜…

@0-vortex 0-vortex merged commit 0434010 into main Mar 25, 2023
@0-vortex 0-vortex deleted the correct-node-ssl-webpack branch March 25, 2023 20:58
@github-actions
Copy link
Contributor

πŸŽ‰ This PR is included in version 1.18.1 πŸŽ‰

The release is available on:

Your semantic-release bot πŸ“¦πŸš€

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant