Skip to content
This repository has been archived by the owner on Sep 26, 2024. It is now read-only.

Bug: my votes array needs global caching and display feedback #272

Closed
2 tasks done
CMCSWEENE opened this issue Jul 31, 2022 · 6 comments · Fixed by #296
Closed
2 tasks done

Bug: my votes array needs global caching and display feedback #272

CMCSWEENE opened this issue Jul 31, 2022 · 6 comments · Fixed by #296
Assignees
@0-vortex
Labels
🐛 bug Something isn't working released on @beta released

Comments

@CMCSWEENE
Copy link

CMCSWEENE commented Jul 31, 2022 •
edited by 0-vortex
Loading

Describe the bug

once signed in with get up, clicking on the upvote button cause page to glitch. After pressing upvote multiple time it works and changes from upvote to vote.

Steps to reproduce

  1. Go to https://hot.opensauced.pizza
  2. Vote on a repository that doesn't exist in https://hot.opensauced.pizza/myVotes
  3. Refresh page
  4. Vote on the previously voted repository that doesn't indicate you vote

Affected services

hot.opensauced.pizza

Platforms

All

Browsers

All

Environment

Production

Additional context

No response

Code of Conduct

  • I agree to follow this project's Code of Conduct

Contributing Docs

  • I agree to follow this project's Contribution Docs
@CMCSWEENE CMCSWEENE added the 🐛 bug Something isn't working label Jul 31, 2022
@CMCSWEENE CMCSWEENE changed the title Bug: Bug: UpvoteGlitchWhenClicked Jul 31, 2022
@0-vortex 0-vortex changed the title Bug: UpvoteGlitchWhenClicked Bug: my votes array needs global caching and display feedback Jul 31, 2022
@0-vortex
Copy link
Contributor

Thanks for catching this, my votes array needs to be cached somehow, either globally or as a hook, it is currently being digested inside HotRepositories.tsx. The voted icon should also reflect whether a user has voted or not, to remove the possibility of failure! 🍕

@bdougie bdougie moved this to Todo in hot.opensauced.pizza Aug 1, 2022
@0-vortex
Copy link
Contributor

0-vortex commented Aug 7, 2022

.take

@github-actions
Copy link

github-actions bot commented Aug 7, 2022

Thanks for taking this on! If you have not already, join the conversation in our Discord

@0-vortex 0-vortex mentioned this issue Aug 7, 2022
Merged
20 tasks
0-vortex added a commit that referenced this issue Aug 7, 2022
@0-vortex
feat: implement global votes array
ad38973 
closes #272
0-vortex added a commit that referenced this issue Aug 8, 2022
@0-vortex
feat: add global vote handler to use voted repos
c80993f 
closes #272
0-vortex added a commit that referenced this issue Aug 9, 2022
@0-vortex
feat: use async hooks and beta api for hot repos (#296)
6b5a06a 
closes #276

closes #272

closes #270
Repository owner moved this from Todo to Done in hot.opensauced.pizza Aug 9, 2022
github-actions bot pushed a commit that referenced this issue Aug 9, 2022
@KrisMannino @open-sauced
chore(minor): release 2.22.0 [skip ci]
9c02063 
## [2.22.0](v2.21.2...v2.22.0) (2022-08-09)

### 🍕 Features

* updated css to respect row in subnav ([#298](#298)) ([3211cf4](3211cf4)), closes [#221](#221)
* use async hooks and beta api for hot repos ([#296](#296)) ([6b5a06a](6b5a06a)), closes [#276](#276) [#272](#272) [#270](#270)
@github-actions
Copy link

github-actions bot commented Aug 9, 2022

🎉 This issue has been resolved in version 2.22.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@github-actions
Copy link

🎉 This issue has been resolved in version 2.24.0-beta.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

@github-actions
Copy link

🎉 This issue has been resolved in version 2.24.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@0-vortex 0-vortex

Labels
🐛 bug Something isn't working released on @beta released
Projects
No open projects
hot.opensauced.pizza
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: use async hooks and beta api open-sauced/hot
2 participants
@0-vortex @CMCSWEENE