Skip to content
This repository has been archived by the owner on Sep 26, 2024. It is now read-only.

Feature: react loading skeleton #276

Closed
2 tasks done
NsdHSO opened this issue Aug 1, 2022 · 10 comments · Fixed by #296
Closed
2 tasks done

Feature: react loading skeleton #276

NsdHSO opened this issue Aug 1, 2022 · 10 comments · Fixed by #296

Comments

@NsdHSO
Copy link
Contributor

NsdHSO commented Aug 1, 2022

Type of feature

🍕 Feature

Current behavior

Affect all the repo. The sooner, the better.

Suggested solution

In open-sauced we have react-loading-skeleton for the user It would be nice to implement this feature in hot to avoid 'break the app' open-sauced

Additional context

No response

Code of Conduct

  • I agree to follow this project's Code of Conduct

Contributing Docs

  • I agree to follow this project's Contribution Docs
@NsdHSO NsdHSO added this to the v3.0 new ui milestone Aug 1, 2022
@0-vortex
Copy link
Contributor

0-vortex commented Aug 1, 2022

I would prefer we first implement something like useAsync and then focus on this issue, which is improving the visual feedback of the async functions. Most of the hot open sauced content relies on data fetching:

  • hot repositories
  • my votes
  • list repositories

Having a standardized UI vs data loading async distinction we can then apply nice skeletons using the proposed library, having this distinction also helps reduce implementation difficulty for this issue, as it would then require installing and adding to the components doing async fetches only! 🍕

@NsdHSO
Copy link
Contributor Author

NsdHSO commented Aug 2, 2022

I don't think in this way, because this feature should be implemented with/without useAsync. But please create a new ticket with this hook.

@NsdHSO NsdHSO removed this from the v3.0 new ui milestone Aug 2, 2022
@0-vortex
Copy link
Contributor

0-vortex commented Aug 2, 2022

I don't think in this way, because this feature should be implemented with/without useAsync. But please create a new ticket with this hook.

You opened the ticket up as a feature, in the sense of feature design, it's something worth discussing. If it is not a feature and just a style: improvement there's not much to talk about and you could just as well screenshot what you are experimenting with as a proposal.

Was also hoping triaging issues could be done as a group effort rather than breaking it apart into multiple issues we are not willing to discuss 😅

@bdougie
Copy link
Member

bdougie commented Aug 2, 2022

FWIW, Suspense and useAsync are related to loading skeletons.

I don't think in this way, because this feature should be implemented with/without useAsync. But please create a new ticket with this hook.

As mentioned in this issue, #270, this is already a solved problem in app.opensauced.pizza.

This is a duplicate of my issue, but not a big deal if this is the place to discuss the implementation. Is this something you are looking to test out @NsdHSO?

@NsdHSO
Copy link
Contributor Author

NsdHSO commented Aug 3, 2022

For skeleton, I created one demo, to did this issue good first issues

@bdougie bdougie moved this to Todo in hot.opensauced.pizza Aug 3, 2022
@0-vortex
Copy link
Contributor

0-vortex commented Aug 7, 2022

.take

@github-actions
Copy link

github-actions bot commented Aug 7, 2022

Thanks for taking this on! If you have not already, join the conversation in our Discord

Repository owner moved this from Todo to Done in hot.opensauced.pizza Aug 9, 2022
github-actions bot pushed a commit that referenced this issue Aug 9, 2022
## [2.22.0](v2.21.2...v2.22.0) (2022-08-09)

### 🍕 Features

* updated css to respect row in subnav ([#298](#298)) ([3211cf4](3211cf4)), closes [#221](#221)
* use async hooks and beta api for hot repos ([#296](#296)) ([6b5a06a](6b5a06a)), closes [#276](#276) [#272](#272) [#270](#270)
@github-actions
Copy link

github-actions bot commented Aug 9, 2022

🎉 This issue has been resolved in version 2.22.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@github-actions
Copy link

🎉 This issue has been resolved in version 2.24.0-beta.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

@github-actions
Copy link

🎉 This issue has been resolved in version 2.24.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
No open projects
Archived in project
Development

Successfully merging a pull request may close this issue.

3 participants