-
-
Notifications
You must be signed in to change notification settings - Fork 148
Feature: react loading skeleton #276
Comments
I would prefer we first implement something like useAsync and then focus on this issue, which is improving the visual feedback of the async functions. Most of the hot open sauced content relies on data fetching:
Having a standardized UI vs data loading async distinction we can then apply nice skeletons using the proposed library, having this distinction also helps reduce implementation difficulty for this issue, as it would then require installing and adding to the components doing async fetches only! 🍕 |
I don't think in this way, because this feature should be implemented with/without |
You opened the ticket up as a feature, in the sense of feature design, it's something worth discussing. If it is not a feature and just a style: improvement there's not much to talk about and you could just as well screenshot what you are experimenting with as a proposal. Was also hoping triaging issues could be done as a group effort rather than breaking it apart into multiple issues we are not willing to discuss 😅 |
FWIW, Suspense and useAsync are related to loading skeletons.
As mentioned in this issue, #270, this is already a solved problem in app.opensauced.pizza. This is a duplicate of my issue, but not a big deal if this is the place to discuss the implementation. Is this something you are looking to test out @NsdHSO? |
For skeleton, I created one demo, to did this issue |
|
Thanks for taking this on! If you have not already, join the conversation in our Discord |
🎉 This issue has been resolved in version 2.22.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
🎉 This issue has been resolved in version 2.24.0-beta.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
🎉 This issue has been resolved in version 2.24.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Type of feature
🍕 Feature
Current behavior
Affect all the repo. The sooner, the better.
Suggested solution
In open-sauced we have
react-loading-skeleton
for the user It would be nice to implement this feature in hot to avoid 'break the app' open-saucedAdditional context
No response
Code of Conduct
Contributing Docs
The text was updated successfully, but these errors were encountered: