This repository has been archived by the owner on Sep 26, 2024. It is now read-only.
fix: Pressing enter when searching no longer goes to about:blank #504
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for hot-sauced-ui ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
one more thing around this issue, is that the user can't just navigate to a repository by just clicking on it in the result list, the user has to click on it to set it as selected then has to press enter on the field, should I work on a fix for that here or with a new issue & pr? |
nickytonline
changed the title
|
@adnanjpg checking in here. Let us know if you are still around to work on this.
Open a new issue. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
this pr fixes #501
What type of PR is this? (check all applicable)
Related Tickets & Documents
fixes #501
Mobile & Desktop Screenshots/Recordings
Steps to QA
try to press enter in the search repositories field, before the repos load
Added to documentation?
[optional] Are there any post-deployment tasks we need to perform?
[optional] What gif best describes this PR or how it makes you feel?