Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature: add delete button to the highlights #906

Closed
2 tasks done
Tracked by #718
dev-phantom opened this issue Feb 23, 2023 · 2 comments · Fixed by #963
Closed
2 tasks done
Tracked by #718

Feature: add delete button to the highlights #906

dev-phantom opened this issue Feb 23, 2023 · 2 comments · Fixed by #963
Assignees
@OgDev-01
Labels
💡 feature high-priority Work on these issues first released on @beta

Comments

@dev-phantom
Copy link
Contributor

Type of feature

🍕 Feature

Current behavior

currently there's no delete button to delete highlight
image

Suggested solution

No response

Additional context

https://insights.opensauced.pizza/user/dev-phantom

Code of Conduct

  • I agree to follow this project's Code of Conduct

Contributing Docs

  • I agree to follow this project's Contribution Docs
@bdougie
Copy link
Member

bdougie commented Feb 24, 2023

This is available in the API. If you need to delete a highlight.

but also happy to take a PR on this. My thought would be adding a delete button to the Edit modal, currently being worked on in #907

@getaheaddev created a delete icon in another design in this unrelated Figma Design.

Screen Shot 2023-02-24 at 6 43 35 AM

@bdougie bdougie mentioned this issue Feb 24, 2023
Closed
11 tasks
@bdougie bdougie changed the title Feature: add deleted button to the highlights Feature: add delete button to the highlights Mar 2, 2023
@bdougie bdougie added the high-priority Work on these issues first label Mar 6, 2023
@OgDev-01 OgDev-01 mentioned this issue Mar 7, 2023
Merged
19 tasks
brandonroberts pushed a commit that referenced this issue Mar 10, 2023
@OgDev-01
feat: add delete highlight implementation (#963)
10575f1 
Fixes #906
github-actions bot pushed a commit that referenced this issue Mar 10, 2023
@OgDev-01 @open-sauced
chore(minor): release 1.34.0-beta.6 on beta channel [skip ci]
a72e223 
## [1.34.0-beta.6](v1.34.0-beta.5...v1.34.0-beta.6) (2023-03-10)

### 🍕 Features

* add delete highlight implementation ([#963](#963)) ([10575f1](10575f1)), closes [#906](#906)
@github-actions
Copy link
Contributor

🎉 This issue has been resolved in version 1.34.0-beta.6 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

github-actions bot pushed a commit that referenced this issue Mar 10, 2023
@0-vortex @open-sauced
chore(minor): release 1.34.0 [skip ci]
99dcfc5 
## [1.34.0](v1.33.0...v1.34.0) (2023-03-10)

### 🍕 Features

* add custom tooltip to pr list icon ([#962](#962)) ([44fa050](44fa050)), closes [#955](#955)
* add delete highlight implementation ([#963](#963)) ([10575f1](10575f1)), closes [#906](#906)
* implement highlight's permanent link ([#957](#957)) ([78ad176](78ad176)), closes [#895](#895) [#950](#950)
* remove the repo click to filter feature & link to github ([#989](#989)) ([6f62b46](6f62b46)), closes [#983](#983)

### 🧑‍💻 Code Refactoring

* add invalid pull url feedback ([#992](#992)) ([28fe15c](28fe15c)), closes [#961](#961)

### 🐛 Bug Fixes

* add Rust to interests options and combine utility function ([#977](#977)) ([28a5270](28a5270)), closes [#976](#976)
* add skeleton wrapper atom to storybook ([#990](#990)) ([780d345](780d345))
* adds more placeholder ([#971](#971)) ([bf5daa7](bf5daa7))
* adjust input body overlap when editing a highlight ([#991](#991)) ([1512f7d](1512f7d))
* fix pointer-events when closing edit dialog ([#987](#987)) ([df6eb2b](df6eb2b))
* update local time option from user settings ([#951](#951)) ([c91a513](c91a513))
ElpisHelle added a commit to ElpisHelle/next.js-tailwindcss that referenced this issue Aug 17, 2023
@ElpisHelle
chore(minor): release 1.34.0-beta.6 on beta channel [skip ci]
c280e8f 
## [1.34.0-beta.6](open-sauced/app@v1.34.0-beta.5...v1.34.0-beta.6) (2023-03-10)

### 🍕 Features

* add delete highlight implementation ([#963](open-sauced/app#963)) ([10575f1](open-sauced/app@10575f1)), closes [#906](open-sauced/app#906)
ElpisHelle added a commit to ElpisHelle/next.js-tailwindcss that referenced this issue Aug 17, 2023
@ElpisHelle
chore(minor): release 1.34.0 [skip ci]
185417e 
## [1.34.0](open-sauced/app@v1.33.0...v1.34.0) (2023-03-10)

### 🍕 Features

* add custom tooltip to pr list icon ([#962](open-sauced/app#962)) ([44fa050](open-sauced/app@44fa050)), closes [#955](open-sauced/app#955)
* add delete highlight implementation ([#963](open-sauced/app#963)) ([10575f1](open-sauced/app@10575f1)), closes [#906](open-sauced/app#906)
* implement highlight's permanent link ([#957](open-sauced/app#957)) ([78ad176](open-sauced/app@78ad176)), closes [#895](open-sauced/app#895) [#950](open-sauced/app#950)
* remove the repo click to filter feature & link to github ([#989](open-sauced/app#989)) ([6f62b46](open-sauced/app@6f62b46)), closes [#983](open-sauced/app#983)

### 🧑‍💻 Code Refactoring

* add invalid pull url feedback ([#992](open-sauced/app#992)) ([28fe15c](open-sauced/app@28fe15c)), closes [#961](open-sauced/app#961)

### 🐛 Bug Fixes

* add Rust to interests options and combine utility function ([#977](open-sauced/app#977)) ([28a5270](open-sauced/app@28a5270)), closes [#976](open-sauced/app#976)
* add skeleton wrapper atom to storybook ([#990](open-sauced/app#990)) ([780d345](open-sauced/app@780d345))
* adds more placeholder ([#971](open-sauced/app#971)) ([bf5daa7](open-sauced/app@bf5daa7))
* adjust input body overlap when editing a highlight ([#991](open-sauced/app#991)) ([1512f7d](open-sauced/app@1512f7d))
* fix pointer-events when closing edit dialog ([#987](open-sauced/app#987)) ([df6eb2b](open-sauced/app@df6eb2b))
* update local time option from user settings ([#951](open-sauced/app#951)) ([c91a513](open-sauced/app@c91a513))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@OgDev-01 OgDev-01

Labels
💡 feature high-priority Work on these issues first released on @beta
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: Add delete highlights implementation open-sauced/app
3 participants
@bdougie @OgDev-01 @dev-phantom