Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: No error on non PR issues #961

Closed
1 of 2 tasks
bdougie opened this issue Mar 6, 2023 · 1 comment · Fixed by #992
Closed
1 of 2 tasks

Feature: No error on non PR issues #961

bdougie opened this issue Mar 6, 2023 · 1 comment · Fixed by #992
Assignees
Labels
🐛 bug Something isn't working high-priority Work on these issues first 👀 needs triage released on @beta
Milestone

Comments

@bdougie
Copy link
Member

bdougie commented Mar 6, 2023

Type of feature

🍕 Feature

Current behavior

Screen Shot 2023-03-06 at 3 31 18 PM

Suggested solution

We should provide an error message when someone tries to submit a non PR

Additional context

No response

Code of Conduct

  • I agree to follow this project's Code of Conduct

Contributing Docs

  • I agree to follow this project's Contribution Docs
@bdougie bdougie added 🐛 bug Something isn't working 👀 needs triage high-priority Work on these issues first labels Mar 6, 2023
@bdougie bdougie added this to the Papercuts milestone Mar 6, 2023
github-actions bot pushed a commit that referenced this issue Mar 10, 2023
## [1.34.0-beta.7](v1.34.0-beta.6...v1.34.0-beta.7) (2023-03-10)

### 🧑‍💻 Code Refactoring

* add invalid pull url feedback ([#992](#992)) ([28fe15c](28fe15c)), closes [#961](#961)
@github-actions
Copy link
Contributor

🎉 This issue has been resolved in version 1.34.0-beta.7 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

github-actions bot pushed a commit that referenced this issue Mar 10, 2023
## [1.34.0](v1.33.0...v1.34.0) (2023-03-10)

### 🍕 Features

* add custom tooltip to pr list icon ([#962](#962)) ([44fa050](44fa050)), closes [#955](#955)
* add delete highlight implementation ([#963](#963)) ([10575f1](10575f1)), closes [#906](#906)
* implement highlight's permanent link ([#957](#957)) ([78ad176](78ad176)), closes [#895](#895) [#950](#950)
* remove the repo click to filter feature & link to github ([#989](#989)) ([6f62b46](6f62b46)), closes [#983](#983)

### 🧑‍💻 Code Refactoring

* add invalid pull url feedback ([#992](#992)) ([28fe15c](28fe15c)), closes [#961](#961)

### 🐛 Bug Fixes

* add Rust to interests options and combine utility function ([#977](#977)) ([28a5270](28a5270)), closes [#976](#976)
* add skeleton wrapper atom to storybook ([#990](#990)) ([780d345](780d345))
* adds more placeholder ([#971](#971)) ([bf5daa7](bf5daa7))
* adjust input body overlap when editing a highlight ([#991](#991)) ([1512f7d](1512f7d))
* fix pointer-events when closing edit dialog ([#987](#987)) ([df6eb2b](df6eb2b))
* update local time option from user settings ([#951](#951)) ([c91a513](c91a513))
ElpisHelle added a commit to ElpisHelle/next.js-tailwindcss that referenced this issue Aug 17, 2023
## [1.34.0-beta.7](open-sauced/app@v1.34.0-beta.6...v1.34.0-beta.7) (2023-03-10)

### 🧑‍💻 Code Refactoring

* add invalid pull url feedback ([#992](open-sauced/app#992)) ([28fe15c](open-sauced/app@28fe15c)), closes [#961](open-sauced/app#961)
ElpisHelle added a commit to ElpisHelle/next.js-tailwindcss that referenced this issue Aug 17, 2023
## [1.34.0](open-sauced/app@v1.33.0...v1.34.0) (2023-03-10)

### 🍕 Features

* add custom tooltip to pr list icon ([#962](open-sauced/app#962)) ([44fa050](open-sauced/app@44fa050)), closes [#955](open-sauced/app#955)
* add delete highlight implementation ([#963](open-sauced/app#963)) ([10575f1](open-sauced/app@10575f1)), closes [#906](open-sauced/app#906)
* implement highlight's permanent link ([#957](open-sauced/app#957)) ([78ad176](open-sauced/app@78ad176)), closes [#895](open-sauced/app#895) [#950](open-sauced/app#950)
* remove the repo click to filter feature & link to github ([#989](open-sauced/app#989)) ([6f62b46](open-sauced/app@6f62b46)), closes [#983](open-sauced/app#983)

### 🧑‍💻 Code Refactoring

* add invalid pull url feedback ([#992](open-sauced/app#992)) ([28fe15c](open-sauced/app@28fe15c)), closes [#961](open-sauced/app#961)

### 🐛 Bug Fixes

* add Rust to interests options and combine utility function ([#977](open-sauced/app#977)) ([28a5270](open-sauced/app@28a5270)), closes [#976](open-sauced/app#976)
* add skeleton wrapper atom to storybook ([#990](open-sauced/app#990)) ([780d345](open-sauced/app@780d345))
* adds more placeholder ([#971](open-sauced/app#971)) ([bf5daa7](open-sauced/app@bf5daa7))
* adjust input body overlap when editing a highlight ([#991](open-sauced/app#991)) ([1512f7d](open-sauced/app@1512f7d))
* fix pointer-events when closing edit dialog ([#987](open-sauced/app#987)) ([df6eb2b](open-sauced/app@df6eb2b))
* update local time option from user settings ([#951](open-sauced/app#951)) ([c91a513](open-sauced/app@c91a513))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐛 bug Something isn't working high-priority Work on these issues first 👀 needs triage released on @beta
Projects
No open projects
Development

Successfully merging a pull request may close this issue.

2 participants