-
Notifications
You must be signed in to change notification settings - Fork 2.4k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
[chore][cmd/telemetrygen] Fix deprecated method usage (#32300)
`grpc.DialContext` has been deprecated in favor of `grpc.NewClient`. The only difference relevant to our usage is that the context is no longer passed in. I investigated, and the context being cancelled and exiting the running sub-goroutine is [handled internally](https://github.com/grpc/grpc-go/blob/d32e66ce27447a0a217464a36fdd3935801c0453/clientconn.go#L135) in an equivalent way to how we were using `grpc.DialContext`, so there shouldn't be any impact here. Resolves #32297
- Loading branch information
Showing
2 changed files
with
4 additions
and
5 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters