[chore][cmd/telemetrygen] Fix deprecated method usage #32300
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mx-psi
approved these changes
Apr 10, 2024
Thanks for pointing this out, fixed. |
codeboten
approved these changes
Apr 10, 2024
songy23
approved these changes
Apr 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
grpc.DialContexthas been deprecated in favor ofgrpc.NewClient. The only difference relevant to our usage is that the context is no longer passed in. I investigated, and the context being cancelled and exiting the running sub-goroutine is handled internally in an equivalent way to how we were usinggrpc.DialContext, so there shouldn't be any impact here.Link to tracking Issue:
Resolves #32297