-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feature gate logs.jsonParserArray doesn't work. #32313
Comments
Pinging code owners:
See Adding Labels via Comments if you do not have permissions to add labels yourself. |
Removing |
…unc 'Build' returns an error (#32501) **Description:** <Describe what has changed.> <!--Ex. Fixing a bug - Describe the bug and how this fixes the issue. Ex. Adding a feature - Explain what this achieves.--> bug: - collector launch fail with '--feature-gates=logs.jsonParserArray' how to fix: 1. `func init()` always register operator to `operator.DefaultRegistry`. 2. when the `jsonArrayParserFeatureGate` is disabled, the func `Build` returns an error. **Link to tracking Issue:** <Issue number if applicable> #32313 --------- Co-authored-by: Daniel Jaglowski <jaglows3@gmail.com>
This issue has been inactive for 60 days. It will be closed in 60 days if there is no activity. To ping code owners by adding a component label, see Adding Labels via Comments, or if you are unsure of which component this issue relates to, please ping Pinging code owners:
See Adding Labels via Comments if you do not have permissions to add labels yourself. |
It looks like this was resolved by #32501, but please let me know if I misunderstood. |
Yes, it has been fixed. |
Component(s)
pkg/stanza
What happened?
Description
After enabling feature gate
logs.jsonParserArray
, when I try to usejson_array_parser
, it still reportsunsupported type 'json_array_parser'
Steps to Reproduce
Try to use
json_array_parser
in a config file. Then launch otelcol-contrib with--feature-gates=logs.jsonParserArray
.Expected Result
It should launch normally.
Actual Result
It reports
unsupported type 'json_array_parser'
and exits.Collector version
v0.95.0
Environment information
Environment
OS: (e.g., "Ubuntu 20.04")
Compiler(if manually compiled): (e.g., "go 14.2")
OpenTelemetry Collector configuration
Log output
Additional context
The parser checks feature gates in
init()
, which seems to run before the command line arguements have been loaded?The text was updated successfully, but these errors were encountered: