Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[pkg/stanza] fix collector start fail with '--feature-gates=logs.json… #32376

Closed

Conversation

li-zeyuan
Copy link
Contributor

Description:
fix bug: collector start fail with '--feature-gates=logs.jsonParserArray'
how to fix: add Gate.featureGateEnableFunc, called when --feature-gates registered

Link to tracking Issue:
#32313

Testing:

Documentation:

@li-zeyuan
Copy link
Contributor Author

@djaglowski
Copy link
Member

Thanks @li-zeyuan. I've approved CI on both PRs.

Hopefully open-telemetry/opentelemetry-collector#9964 can be merged quickly but if not we can look at registering always and then failing later. It's not ideal though so I appreciate the effort to fix this in the featuregate package.

@li-zeyuan
Copy link
Contributor Author

Thanks @li-zeyuan. I've approved CI on both PRs.

Hopefully open-telemetry/opentelemetry-collector#9964 can be merged quickly but if not we can look at registering always and then failing later. It's not ideal though so I appreciate the effort to fix this in the featuregate package.

open-telemetry/opentelemetry-collector#9964 It's backward compatible

After the merger of open-telemetry/opentelemetry-collector#9964 is successful, I will modify the version of 'go.opentelemetry.io/collector/featuregate' in go.mod. Is that okay?

@djaglowski
Copy link
Member

Thanks @li-zeyuan. I've approved CI on both PRs.
Hopefully open-telemetry/opentelemetry-collector#9964 can be merged quickly but if not we can look at registering always and then failing later. It's not ideal though so I appreciate the effort to fix this in the featuregate package.

open-telemetry/opentelemetry-collector#9964 It's backward compatible

After the merger of open-telemetry/opentelemetry-collector#9964 is successful, I will modify the version of 'go.opentelemetry.io/collector/featuregate' in go.mod. Is that okay?

This change doesn't work without open-telemetry/opentelemetry-collector#9964 so backwards compatibility isn't a concern. I think likely we can get that one merged quickly though.

@li-zeyuan
Copy link
Contributor Author

@djaglowski
Sorry, I thought of another implementation method, resubmit a MR

@li-zeyuan li-zeyuan closed this Apr 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants