[pkg/stanza] Fileconsumer test TestExcludeOlderThanFilter/exclude_some_files failing

[crobert-1]

Component(s)

pkg/stanza

Describe the issue you're reporting

CI/CD failure link

Note that this failure was on Windows

=== FAIL: fileconsumer/matcher/internal/filter TestExcludeOlderThanFilter/exclude_some_files (0.01s)
    exclude_test.go:114: 
        	Error Trace:	D:/a/opentelemetry-collector-contrib/opentelemetry-collector-contrib/pkg/stanza/fileconsumer/matcher/internal/filter/exclude_test.go:114
        	Error:      	Not equal: 
        	            	expected: []string{"a.log"}
        	            	actual  : []string{"a.log", "b.log"}
        	            	
        	            	Diff:
        	            	--- Expected
        	            	+++ Actual
        	            	@@ -1,3 +1,4 @@
        	            	-([]string) (len=1) {
        	            	- (string) (len=5) "a.log"
        	            	+([]string) (len=2) {
        	            	+ (string) (len=5) "a.log",
        	            	+ (string) (len=5) "b.log"
        	            	 }
        	Test:       	TestExcludeOlderThanFilter/exclude_some_files

[github-actions]

Pinging code owners for pkg/stanza: @djaglowski. See Adding Labels via Comments if you do not have permissions to add labels yourself.

[github-actions]

Pinging code owners:

• pkg/stanza: @djaglowski

See Adding Labels via Comments if you do not have permissions to add labels yourself.

[djaglowski]

cc @ycombinator

[ycombinator]

Thanks @djaglowski, will look into this ASAP.

[ycombinator]

This is not failing for me locally (on a Mac) so this is likely a Windows-specific issue.

# On my Mac
$ go test ./fileconsumer/matcher/internal/filter/... -test.run TestExcludeOlderThanFilter -count 1000
ok  	github.com/open-telemetry/opentelemetry-collector-contrib/pkg/stanza/fileconsumer/matcher/internal/filter	3.130s

Also, I'm not seeing this test fail regularly in CI so it looks to be a flaky test.

[djaglowski]

Thanks @ycombinator. Makes sense that it's a flaky test otherwise it probably would have prevented us merging the PR.

I think if it's not a quick fix we should skip the test for now. Either way, we'll need to get to the bottom of it and fix it.

[ycombinator]

I think if it's not a quick fix we should skip the test for now. Either way, we'll need to get to the bottom of it and fix it.

The fix might be quick but I don't know when I'll have time to test this out on Windows. So in that sense, it might not be a quick fix.

Instead of skipping that test case entirely, perhaps we could only skip it on Windows, referencing this issue here? I can put up a PR for that pretty quickly.

[djaglowski]

Good idea, thank you!

[ycombinator]

PR to skip the flaky test only on Windows: #32848

[ChrsMark]

It seems this issue is legit. Shall we remove the needs triage label?

[github-actions]

This issue has been inactive for 60 days. It will be closed in 60 days if there is no activity. To ping code owners by adding a component label, see Adding Labels via Comments, or if you are unsure of which component this issue relates to, please ping @open-telemetry/collector-contrib-triagers. If this issue is still relevant, please ping the code owners or leave a comment explaining why it is still relevant. Otherwise, please close it.

Pinging code owners:

• pkg/stanza: @djaglowski

See Adding Labels via Comments if you do not have permissions to add labels yourself.

[ChrsMark]

Still valid.

[djaglowski]

I think this ultimately requires a solution to the windows timing issue. More details on this issue.