Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[pkg/stanza] Skipping flaky test case TestExcludeOlderThanFilter/exclude_some_files on Windows #32848

Merged
merged 1 commit into from
May 3, 2024
Merged

[pkg/stanza] Skipping flaky test case TestExcludeOlderThanFilter/exclude_some_files on Windows #32848

merged 1 commit into from
May 3, 2024

Conversation

ycombinator
Copy link
Contributor

Description:
This PR skips the test case TestExcludeOlderThanFilter/exclude_some_files only on Windows because it appears to be flaky there.

Link to tracking Issue:
#32838

@ycombinator ycombinator requested a review from djaglowski as a code owner May 3, 2024 18:01
@ycombinator ycombinator requested a review from a team May 3, 2024 18:01
@ycombinator ycombinator mentioned this pull request May 3, 2024
Open
@crobert-1 crobert-1 added Run Windows Enable running windows test on a PR Skip Changelog PRs that do not require a CHANGELOG.md entry labels May 3, 2024
crobert-1
crobert-1 approved these changes May 3, 2024
View reviewed changes
Copy link
Member

@crobert-1 crobert-1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Logic looks good to me, we should check the test run once it's complete to make sure the test was successfully skipped 👍

@djaglowski djaglowski merged commit f584d29 into open-telemetry:main May 3, 2024
185 of 205 checks passed
@github-actions github-actions bot added this to the next release milestone May 3, 2024
@djaglowski
Copy link
Member

Confirmed it was skipped:

=== SKIP: fileconsumer/matcher/internal/filter TestExcludeOlderThanFilter/exclude_some_files (0.00s)
    exclude_test.go:83: Skipping test case: Flaky test case on Windows: https://github.com/open-telemetry/opentelemetry-collector-contrib/issues/32838

@ycombinator ycombinator deleted the stanza-skip-TestExcludeOlderThanFilter-test-case-windows branch May 3, 2024 18:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@crobert-1 crobert-1 crobert-1 approved these changes

@djaglowski djaglowski Awaiting requested review from djaglowski djaglowski is a code owner

Assignees

@fatsheep9146 fatsheep9146

Labels
pkg/stanza Run Windows Enable running windows test on a PR Skip Changelog PRs that do not require a CHANGELOG.md entry
Projects
None yet
Milestone
v0.100.0
Development

Successfully merging this pull request may close these issues.
4 participants
@ycombinator @djaglowski @crobert-1 @fatsheep9146