-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New component: Log deduplication processor #34118
Comments
Do you only intend to dedup on attributes? What about timestamps and log body? |
log bodies would be deduped by default, the |
We have a processor with similar functionality in our agent: https://github.com/observIQ/bindplane-agent/tree/release/v1.56.0/processor/logdeduplicationprocessor We ended up storing the first/last observed timestamp on the attributes, as well as storing the count of deduped logs as an attribute. It seems like it could be worth considering doing something similar here as well. It would be awesome to have functionality like this here in contrib, deduping logs is very useful. |
@BinaryFissionGames would you consider donating the component from that repo here? Seems like it would cover a lot of functionality already |
@codeboten Yeah, we'd be happy to donate the component to contrib. |
I can sponsor this. |
Thanks @djaglowski! |
Related spec issue: open-telemetry/opentelemetry-specification#3931 |
@BinaryFissionGames would you like to do the initial PRs to make the component a reality or would you prefer if I did? |
@codeboten I'm a bit tight on time at the moment, if you're able to get a start on it that would be awesome. |
Thanks @BinaryFissionGames - I'll prepare a PR with the code from your repo. |
PR created @BinaryFissionGames would be great for you review and approve on behalf of yourself & ObserveIQ. |
**Description:** Starts the donation of the [logdedupprocessor](https://github.com/observIQ/bindplane-agent/tree/release/v1.58.0/processor/logdeduplicationprocessor) from ObserveIQ's Bindplane agent on behalf of @BinaryFissionGames. **Link to tracking Issue:** - Closes #34118 **Testing:** Includes unit tests. **Documentation:** --------- Co-authored-by: Brandon Johnson <binaryfissiongames@gmail.com> Co-authored-by: Daniel Jaglowski <jaglows3@gmail.com>
**Description:** <Describe what has changed.> <!--Ex. Fixing a bug - Describe the bug and how this fixes the issue. Ex. Adding a feature - Explain what this achieves.--> I noticed in the PR introducing this component that the README was missing the generic header that all other components have. This is added by `mdatagen` when the README has the `<!-- status autogenerated section -->` and `<!-- end autogenerated section -->` lines included. I also removed the section about supported pipelines, as the added header should make this clear enough. **Link to tracking Issue:** <Issue number if applicable> #34118
…emetry#34465) **Description:** Starts the donation of the [logdedupprocessor](https://github.com/observIQ/bindplane-agent/tree/release/v1.58.0/processor/logdeduplicationprocessor) from ObserveIQ's Bindplane agent on behalf of @BinaryFissionGames. **Link to tracking Issue:** - Closes open-telemetry#34118 **Testing:** Includes unit tests. **Documentation:** --------- Co-authored-by: Brandon Johnson <binaryfissiongames@gmail.com> Co-authored-by: Daniel Jaglowski <jaglows3@gmail.com>
…#34488) **Description:** <Describe what has changed.> <!--Ex. Fixing a bug - Describe the bug and how this fixes the issue. Ex. Adding a feature - Explain what this achieves.--> I noticed in the PR introducing this component that the README was missing the generic header that all other components have. This is added by `mdatagen` when the README has the `<!-- status autogenerated section -->` and `<!-- end autogenerated section -->` lines included. I also removed the section about supported pipelines, as the added header should make this clear enough. **Link to tracking Issue:** <Issue number if applicable> open-telemetry#34118
The purpose and use-cases of the new component
We're working to put together a log de-duplication processor at Honeycomb and wanted to get the temperature of the community for hosting such a component in the contrib repository.
Example configuration for the component
Telemetry data types supported
logs
Is this a vendor-specific component?
Code Owner(s)
@codeboten @MikeGoldsmith
Sponsor (optional)
No response
Additional context
No response
The text was updated successfully, but these errors were encountered: