-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[processor/logdeduplicationprocessor] Add logdedupprocessor #34465
[processor/logdeduplicationprocessor] Add logdedupprocessor #34465
Conversation
Co-authored-by: Brandon Johnson <binaryfissiongames@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good to me as the initial pass, pinging @djaglowski to take a look.
Thanks for taking this on!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Generally looks good to me. I recognize this is a preliminary commit but I used the opportunity to give it a closer look. My feedback can be set aside for future PRs if there's a preference to have a cleaner copy of the original source.
I wanted to get a approval from @BinaryFissionGames at this PR is on their behalf. After that I also have some suggestions. I'm happy to address your feedback either in this PR or in subsequent PRs so we can make more isolated changes. |
Co-authored-by: Daniel Jaglowski <jaglows3@gmail.com>
@djaglowski I think I've addressed all the immediate feedback and created tracking issues for the others:
Feel free to assign these to me. |
…emetry#34465) **Description:** Starts the donation of the [logdedupprocessor](https://github.com/observIQ/bindplane-agent/tree/release/v1.58.0/processor/logdeduplicationprocessor) from ObserveIQ's Bindplane agent on behalf of @BinaryFissionGames. **Link to tracking Issue:** - Closes open-telemetry#34118 **Testing:** Includes unit tests. **Documentation:** --------- Co-authored-by: Brandon Johnson <binaryfissiongames@gmail.com> Co-authored-by: Daniel Jaglowski <jaglows3@gmail.com>
Description:
Starts the donation of the logdedupprocessor from ObserveIQ's Bindplane agent on behalf of @BinaryFissionGames.
Link to tracking Issue:
Testing:
Includes unit tests.
Documentation: