Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Xray Exporter Missing Documentation on Annotation Indexing Feature #34182

Closed
arun-annamalai opened this issue Jul 21, 2024 · 2 comments
Closed

Xray Exporter Missing Documentation on Annotation Indexing Feature #34182

arun-annamalai opened this issue Jul 21, 2024 · 2 comments
Labels
bug Something isn't working documentation Improvements or additions to documentation exporter/awsxray needs triage New item requiring triage

Comments

@arun-annamalai
Copy link
Contributor

Component(s)

exporter/awsxray

What happened?

Description

The following PR adds the functionality to index span attributes as Xray annotations in code. #17855.

Expected Result

This new functionality should be documented in the AWS Xray exporter readme

Collector version

Latest

Environment information

Environment

OS: (e.g., "Ubuntu 20.04")
Compiler(if manually compiled): (e.g., "go 14.2")

OpenTelemetry Collector configuration

No response

Log output

No response

Additional context

No response
@arun-annamalai arun-annamalai added bug Something isn't working needs triage New item requiring triage labels Jul 21, 2024
@github-actions GitHub Actions
Copy link
Contributor

Pinging code owners:

See Adding Labels via Comments if you do not have permissions to add labels yourself.

@arun-annamalai arun-annamalai mentioned this issue Jul 21, 2024
Merged
@crobert-1 crobert-1 added the documentation Improvements or additions to documentation label Jul 22, 2024
@github-actions github-actions bot mentioned this issue Jul 23, 2024
Closed
mx-psi pushed a commit that referenced this issue Jul 26, 2024
@arun-annamalai
Update xrayexporter documentation on indexing attributes (#34183)
49cee31 
**Description:** <Describe what has changed.>
<!--Ex. Fixing a bug - Describe the bug and how this fixes the issue.
Ex. Adding a feature - Explain what this achieves.-->
Adding Xray Exporter Documentation - Shows users how to use dynamically
indexed attributes within the SDK with Xray

**Link to tracking Issue:**
#34182

**Testing:** N/A

**Documentation:** Update xrayexporter documentation on indexing
attributes
@srprash
Copy link
Contributor

srprash commented Jul 29, 2024

@arun-annamalai Since the PR is merged, can we close this issue?

@github-actions github-actions bot mentioned this issue Jul 30, 2024
Closed
@mx-psi mx-psi closed this as completed Jul 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working documentation Improvements or additions to documentation exporter/awsxray needs triage New item requiring triage
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@mx-psi @arun-annamalai @srprash @crobert-1