Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[exporter/awsxray] Add support for AWS X-Ray annotations attribute in exporter. #17855

Merged
merged 1 commit into from
Jan 26, 2023

Conversation

jefchien
Copy link
Contributor

Description: If the original segment received by the awsxrayreceiver had annotations, adds an aws.xray.annotations attribute to the translated spans. The attribute is a slice attribute that contains each of the string keys. If found on the span, the awsxrayexporter will use them in addition to the indexed_attributes configuration field when categorizing the attributes.

Link to tracking Issue: #17550

Testing: Updated and added unit tests.

Documentation: None

@runforesight
Copy link

runforesight bot commented Jan 19, 2023

Foresight Summary

    
Major Impacts

build-and-test-windows duration(5 seconds) has decreased 41 minutes 27 seconds compared to main branch avg(41 minutes 32 seconds).
View More Details

⭕  build-and-test-windows workflow has finished in 5 seconds (41 minutes 16 seconds less than main branch avg.) and finished at 25th Jan, 2023.


Job Failed Steps Tests
windows-unittest-matrix -     🔗  N/A See Details
windows-unittest -     🔗  N/A See Details

✅  tracegen workflow has finished in 1 minute 12 seconds (1 minute 15 seconds less than main branch avg.) and finished at 25th Jan, 2023.


Job Failed Steps Tests
build-dev -     🔗  N/A See Details
publish-latest -     🔗  N/A See Details
publish-stable -     🔗  N/A See Details

✅  telemetrygen workflow has finished in 2 minutes 45 seconds and finished at 25th Jan, 2023.


Job Failed Steps Tests
build-dev -     🔗  N/A See Details
publish-latest -     🔗  N/A See Details
publish-stable -     🔗  N/A See Details

✅  check-links workflow has finished in 3 minutes 3 seconds (⚠️ 1 minute 11 seconds more than main branch avg.) and finished at 25th Jan, 2023.


Job Failed Steps Tests
changed files -     🔗  N/A See Details
check-links -     🔗  N/A See Details

✅  changelog workflow has finished in 3 minutes 25 seconds (⚠️ 1 minute 20 seconds more than main branch avg.) and finished at 25th Jan, 2023.


Job Failed Steps Tests
changelog -     🔗  N/A See Details

✅  prometheus-compliance-tests workflow has finished in 14 minutes 8 seconds (⚠️ 6 minutes 32 seconds more than main branch avg.) and finished at 25th Jan, 2023.


Job Failed Steps Tests
prometheus-compliance-tests -     🔗  ✅ 21  ❌ 0  ⏭ 0    🔗 See Details

✅  load-tests workflow has finished in 20 minutes 11 seconds (⚠️ 5 minutes 51 seconds more than main branch avg.) and finished at 25th Jan, 2023.


Job Failed Steps Tests
loadtest (TestIdleMode) -     🔗  ✅ 1  ❌ 0  ⏭ 0    🔗 See Details
loadtest (TestTraceAttributesProcessor) -     🔗  ✅ 3  ❌ 0  ⏭ 0    🔗 See Details
loadtest (TestMetric10kDPS|TestMetricsFromFile) -     🔗  ✅ 6  ❌ 0  ⏭ 0    🔗 See Details
loadtest (TestTraceNoBackend10kSPS|TestTrace1kSPSWithAttrs) -     🔗  ✅ 8  ❌ 0  ⏭ 0    🔗 See Details
loadtest (TestTraceBallast1kSPSWithAttrs|TestTraceBallast1kSPSAddAttrs) -     🔗  ✅ 10  ❌ 0  ⏭ 0    🔗 See Details
loadtest (TestMetricResourceProcessor|TestTrace10kSPS) -     🔗  ✅ 12  ❌ 0  ⏭ 0    🔗 See Details
loadtest (TestBallastMemory|TestLog10kDPS) -     🔗  ✅ 19  ❌ 0  ⏭ 0    🔗 See Details
setup-environment -     🔗  N/A See Details

✅  build-and-test workflow has finished in 44 minutes 4 seconds (8 minutes 5 seconds less than main branch avg.) and finished at 26th Jan, 2023.


Job Failed Steps Tests
lint-matrix (other) -     🔗  N/A See Details
lint -     🔗  N/A See Details
cross-compile (darwin, amd64) -     🔗  N/A See Details
cross-compile (darwin, arm64) -     🔗  N/A See Details
cross-compile (linux, 386) -     🔗  N/A See Details
cross-compile (linux, amd64) -     🔗  N/A See Details
cross-compile (linux, arm) -     🔗  N/A See Details
cross-compile (linux, arm64) -     🔗  N/A See Details
cross-compile (linux, ppc64le) -     🔗  N/A See Details
cross-compile (windows, 386) -     🔗  N/A See Details
cross-compile (windows, amd64) -     🔗  N/A See Details
build-package (deb) -     🔗  N/A See Details
build-package (rpm) -     🔗  N/A See Details
windows-msi -     🔗  N/A See Details
publish-check -     🔗  N/A See Details
publish-stable -     🔗  N/A See Details
publish-dev -     🔗  N/A See Details

🔎 See details on Foresight

*You can configure Foresight comments in your organization settings page.

@willarmiros
Copy link
Contributor

@wangzlei will review on my behalf

Copy link
Member

@mxiamxia mxiamxia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks

@dmitryax
Copy link
Member

@jefchien please rebase

@jefchien jefchien force-pushed the forward-xray-annotations branch from 264b7a5 to e8eb73e Compare January 24, 2023 16:12
@jefchien
Copy link
Contributor Author

@dmitryax rebased the PR

@Aneurysm9 Aneurysm9 added the ready to merge Code review completed; ready to merge by maintainers label Jan 24, 2023
Add to generated spans in AWS X-Ray receiver.
@jefchien jefchien force-pushed the forward-xray-annotations branch from e8eb73e to 0ed05d4 Compare January 25, 2023 15:07
@jefchien
Copy link
Contributor Author

Rebased again due to go.mod merge conflict

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
exporter/awsxray internal/aws ready to merge Code review completed; ready to merge by maintainers receiver/awsxray
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants