-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[receiver/datadog] Missing DDAgentFeaturesDiscovery #34718
Labels
Comments
melchiormoulin
added
bug
Something isn't working
needs triage
New item requiring triage
labels
Aug 16, 2024
Pinging code owners:
See Adding Labels via Comments if you do not have permissions to add labels yourself. |
Go ahead! |
jpkrohling
pushed a commit
that referenced
this issue
Aug 19, 2024
**Description:** <Describe what has changed.> <!--Ex. Fixing a bug - Describe the bug and how this fixes the issue. Ex. Adding a feature - Explain what this achieves.--> **Link to tracking Issue:** Fix #34718 **Testing:** this otel config ``` receivers: datadog: endpoint: 0.0.0.0:8080 read_timeout: 60s processors: probabilistic_sampler: sampling_percentage: 0 exporters: debug: verbosity: detailed service: pipelines: traces: receivers: [datadog] processors: [probabilistic_sampler] exporters: [debug] ``` tcpdump on 8080 port and having this http request performed : ``` PUT /v0.4/traces HTTP/1.1 Content-Type: application/msgpack Content-Length: 0 Host: 10.0.0.2:8080 Connection: Keep-Alive Accept-Encoding: gzip User-Agent: okhttp/3.12.15 HTTP/1.1 400 Bad Request Content-Type: text/plain; charset=utf-8 X-Content-Type-Options: nosniff Date: Sun, 18 Aug 2024 22:06:39 GMT Content-Length: 23 Fake featuresdiscovery ``` **Documentation:** <Describe the documentation added.>
f7o
pushed a commit
to f7o/opentelemetry-collector-contrib
that referenced
this issue
Sep 12, 2024
**Description:** <Describe what has changed.> <!--Ex. Fixing a bug - Describe the bug and how this fixes the issue. Ex. Adding a feature - Explain what this achieves.--> **Link to tracking Issue:** Fix open-telemetry#34718 **Testing:** this otel config ``` receivers: datadog: endpoint: 0.0.0.0:8080 read_timeout: 60s processors: probabilistic_sampler: sampling_percentage: 0 exporters: debug: verbosity: detailed service: pipelines: traces: receivers: [datadog] processors: [probabilistic_sampler] exporters: [debug] ``` tcpdump on 8080 port and having this http request performed : ``` PUT /v0.4/traces HTTP/1.1 Content-Type: application/msgpack Content-Length: 0 Host: 10.0.0.2:8080 Connection: Keep-Alive Accept-Encoding: gzip User-Agent: okhttp/3.12.15 HTTP/1.1 400 Bad Request Content-Type: text/plain; charset=utf-8 X-Content-Type-Options: nosniff Date: Sun, 18 Aug 2024 22:06:39 GMT Content-Length: 23 Fake featuresdiscovery ``` **Documentation:** <Describe the documentation added.>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Component(s)
receiver/datadog
What happened?
Description
Currently Datadog receiver does not implement GET /info needed for featuresdiscovery by Datadog SDK
This lead to the fallback mecanism of Datadog SDK which probe opentelemetry collector tracing endpoint with Content-lenght: 0 which lead to a stacktrace
Steps to Reproduce
Expected Result
No stacktrace.
Actual Result
Collector version
v0.104.0
Environment information
Environment
OS: (e.g., "Ubuntu 20.04")
Compiler(if manually compiled): (e.g., "go 14.2")
OpenTelemetry Collector configuration
Log output
No response
Additional context
I can handle the fix.
To quick fix we can just check content length:0 of the http request and return same response code 400.
The text was updated successfully, but these errors were encountered: