Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[receiver/datadog] fix feature discovery #34726

Merged

Conversation

melchiormoulin
Copy link
Contributor

@melchiormoulin melchiormoulin commented Aug 18, 2024

Description:

Link to tracking Issue:
Fix #34718

Testing:
this otel config

receivers:
  datadog:
    endpoint: 0.0.0.0:8080
    read_timeout: 60s

processors:
  probabilistic_sampler:
    sampling_percentage: 0

exporters:
  debug:
    verbosity: detailed

service:
  pipelines:
    traces:
      receivers: [datadog]
      processors: [probabilistic_sampler]
      exporters: [debug] 

tcpdump on 8080 port and having this http request performed :

PUT /v0.4/traces HTTP/1.1
Content-Type: application/msgpack
Content-Length: 0
Host: 10.0.0.2:8080
Connection: Keep-Alive
Accept-Encoding: gzip
User-Agent: okhttp/3.12.15

HTTP/1.1 400 Bad Request
Content-Type: text/plain; charset=utf-8
X-Content-Type-Options: nosniff
Date: Sun, 18 Aug 2024 22:06:39 GMT
Content-Length: 23

Fake featuresdiscovery

Documentation:

@jpkrohling
Copy link
Member

Looks like there are some linting failures. You can run make lint locally to check what's wrong.

@melchiormoulin
Copy link
Contributor Author

i don't get the new error , can you help me please ?

  if [[ success == cancelled ]]
  then
    echo "All matrix jobs passed!"
  else
    echo "One or more matrix jobs failed."
    false
  fi
  shell: /usr/bin/bash -e {0}
  env:
    TEST_RESULTS: testbed/tests/results/junit/results.xml
    SEGMENT_DOWNLOAD_TIMEOUT_MINS: 2
One or more matrix jobs failed.
Error: Process completed with exit code 1.

@jpkrohling
Copy link
Member

Looks like it was just a fluke. All is green now. Thank you for your contribution!

@jpkrohling jpkrohling merged commit 373d6af into open-telemetry:main Aug 19, 2024
156 checks passed
@github-actions github-actions bot added this to the next release milestone Aug 19, 2024
f7o pushed a commit to f7o/opentelemetry-collector-contrib that referenced this pull request Sep 12, 2024
**Description:** <Describe what has changed.>
<!--Ex. Fixing a bug - Describe the bug and how this fixes the issue.
Ex. Adding a feature - Explain what this achieves.-->

**Link to tracking Issue:** 
Fix
open-telemetry#34718

**Testing:** 
this otel config

```
receivers:
  datadog:
    endpoint: 0.0.0.0:8080
    read_timeout: 60s

processors:
  probabilistic_sampler:
    sampling_percentage: 0

exporters:
  debug:
    verbosity: detailed

service:
  pipelines:
    traces:
      receivers: [datadog]
      processors: [probabilistic_sampler]
      exporters: [debug] 
```
tcpdump on 8080 port and having this http request performed : 
```
PUT /v0.4/traces HTTP/1.1
Content-Type: application/msgpack
Content-Length: 0
Host: 10.0.0.2:8080
Connection: Keep-Alive
Accept-Encoding: gzip
User-Agent: okhttp/3.12.15

HTTP/1.1 400 Bad Request
Content-Type: text/plain; charset=utf-8
X-Content-Type-Options: nosniff
Date: Sun, 18 Aug 2024 22:06:39 GMT
Content-Length: 23

Fake featuresdiscovery
```
**Documentation:** <Describe the documentation added.>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[receiver/datadog] Missing DDAgentFeaturesDiscovery
3 participants