-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[receiver/datadog] fix feature discovery #34726
Merged
jpkrohling
merged 6 commits into
open-telemetry:main
from
melchiormoulin:datadogreceiver-featurediscovery
Aug 19, 2024
Merged
[receiver/datadog] fix feature discovery #34726
jpkrohling
merged 6 commits into
open-telemetry:main
from
melchiormoulin:datadogreceiver-featurediscovery
Aug 19, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
melchiormoulin
requested review from
jpkrohling and
MovieStoreGuy
as code owners
August 18, 2024 22:22
jpkrohling
approved these changes
Aug 19, 2024
Looks like there are some linting failures. You can run |
i don't get the new error , can you help me please ?
|
Looks like it was just a fluke. All is green now. Thank you for your contribution! |
f7o
pushed a commit
to f7o/opentelemetry-collector-contrib
that referenced
this pull request
Sep 12, 2024
**Description:** <Describe what has changed.> <!--Ex. Fixing a bug - Describe the bug and how this fixes the issue. Ex. Adding a feature - Explain what this achieves.--> **Link to tracking Issue:** Fix open-telemetry#34718 **Testing:** this otel config ``` receivers: datadog: endpoint: 0.0.0.0:8080 read_timeout: 60s processors: probabilistic_sampler: sampling_percentage: 0 exporters: debug: verbosity: detailed service: pipelines: traces: receivers: [datadog] processors: [probabilistic_sampler] exporters: [debug] ``` tcpdump on 8080 port and having this http request performed : ``` PUT /v0.4/traces HTTP/1.1 Content-Type: application/msgpack Content-Length: 0 Host: 10.0.0.2:8080 Connection: Keep-Alive Accept-Encoding: gzip User-Agent: okhttp/3.12.15 HTTP/1.1 400 Bad Request Content-Type: text/plain; charset=utf-8 X-Content-Type-Options: nosniff Date: Sun, 18 Aug 2024 22:06:39 GMT Content-Length: 23 Fake featuresdiscovery ``` **Documentation:** <Describe the documentation added.>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Link to tracking Issue:
Fix #34718
Testing:
this otel config
tcpdump on 8080 port and having this http request performed :
Documentation: