Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[datadogreceiver] /api/v1/check_run returns OK, instead of JSON status: ok #36027

Closed
jdgeisler opened this issue Oct 28, 2024 · 1 comment · Fixed by #36029
Closed

[datadogreceiver] /api/v1/check_run returns OK, instead of JSON status: ok #36027

jdgeisler opened this issue Oct 28, 2024 · 1 comment · Fixed by #36029
Labels
bug Something isn't working needs triage New item requiring triage receiver/datadog

Comments

@jdgeisler
Copy link
Contributor

jdgeisler commented Oct 28, 2024 •
edited
Loading

Component(s)

receiver/datadog

What happened?

Description

Related to #35743

Response for the /api/v1/check_run endpoint should also be

{
  "status": "ok"
}

This is documented in the datadog service checks api here https://docs.datadoghq.com/api/latest/service-checks/

Collector version

latest

Environment information

No response

OpenTelemetry Collector configuration

No response

Log output

No response

Additional context

No response
@jdgeisler jdgeisler added bug Something isn't working needs triage New item requiring triage labels Oct 28, 2024
@github-actions GitHub Actions
Copy link
Contributor

Pinging code owners:

See Adding Labels via Comments if you do not have permissions to add labels yourself.

This was referenced Oct 28, 2024
Closed
Merged
@github-actions github-actions bot mentioned this issue Oct 29, 2024
Closed
jpbarto pushed a commit to jpbarto/opentelemetry-collector-contrib that referenced this issue Oct 29, 2024
@jdgeisler @jpbarto
[receiver/datadogreceiver] Fix /api/v1/check_run response to return J…
65d417c 
…SON status: ok (open-telemetry#36029)

<!--Ex. Fixing a bug - Describe the bug and how this fixes the issue.
Ex. Adding a feature - Explain what this achieves.-->
#### Description

Changing the `/api/v1/check_run` response for service checks to be on
par with the datadog api spec as per
https://docs.datadoghq.com/api/latest/service-checks/

This is the same implementation as the PR for the series endpoints
open-telemetry#35744

<!-- Issue number (e.g. open-telemetry#1234) or full URL to issue, if applicable. -->
#### Link to tracking issue

Fixes
open-telemetry#36027

<!--Describe what testing was performed and which tests were added.-->
#### Testing

Unit tests updated and are passing

<!--Describe the documentation added.-->
#### Documentation

Changelog updated
zzhlogin pushed a commit to zzhlogin/opentelemetry-collector-contrib-aws that referenced this issue Nov 12, 2024
@jdgeisler @zzhlogin
[receiver/datadogreceiver] Fix /api/v1/check_run response to return J…
f80ad02 
…SON status: ok (open-telemetry#36029)

<!--Ex. Fixing a bug - Describe the bug and how this fixes the issue.
Ex. Adding a feature - Explain what this achieves.-->
#### Description

Changing the `/api/v1/check_run` response for service checks to be on
par with the datadog api spec as per
https://docs.datadoghq.com/api/latest/service-checks/

This is the same implementation as the PR for the series endpoints
open-telemetry#35744

<!-- Issue number (e.g. open-telemetry#1234) or full URL to issue, if applicable. -->
#### Link to tracking issue

Fixes
open-telemetry#36027

<!--Describe what testing was performed and which tests were added.-->
#### Testing

Unit tests updated and are passing

<!--Describe the documentation added.-->
#### Documentation

Changelog updated
sbylica-splunk pushed a commit to sbylica-splunk/opentelemetry-collector-contrib that referenced this issue Dec 17, 2024
@jdgeisler @sbylica-splunk
[receiver/datadogreceiver] Fix /api/v1/check_run response to return J…
089ba2c 
…SON status: ok (open-telemetry#36029)

<!--Ex. Fixing a bug - Describe the bug and how this fixes the issue.
Ex. Adding a feature - Explain what this achieves.-->
#### Description

Changing the `/api/v1/check_run` response for service checks to be on
par with the datadog api spec as per
https://docs.datadoghq.com/api/latest/service-checks/

This is the same implementation as the PR for the series endpoints
open-telemetry#35744

<!-- Issue number (e.g. open-telemetry#1234) or full URL to issue, if applicable. -->
#### Link to tracking issue

Fixes
open-telemetry#36027

<!--Describe what testing was performed and which tests were added.-->
#### Testing

Unit tests updated and are passing

<!--Describe the documentation added.-->
#### Documentation

Changelog updated
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working needs triage New item requiring triage receiver/datadog
Projects
None yet
Milestone
No milestone
1 participant
@jdgeisler