Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[receiver/datadogreceiver] Fix 202 response for series endpoints to be on par with DD api spec #35744

Merged
merged 3 commits into from
Oct 15, 2024

Conversation

wiardvanrij
Copy link
Contributor

@wiardvanrij wiardvanrij commented Oct 11, 2024

Description

Changes the responses to be on par with the datadog api spec as per: https://docs.datadoghq.com/api/latest/metrics/?code-lang=go

Link to tracking issue

Fixes #35743

Testing

Unit test is updated

Documentation

Added changelog, no other docs seem to be required

@MovieStoreGuy MovieStoreGuy merged commit 8b67271 into open-telemetry:main Oct 15, 2024
158 checks passed
@github-actions github-actions bot added this to the next release milestone Oct 15, 2024
MovieStoreGuy pushed a commit that referenced this pull request Oct 29, 2024
…SON status: ok (#36029)

<!--Ex. Fixing a bug - Describe the bug and how this fixes the issue.
Ex. Adding a feature - Explain what this achieves.-->
#### Description

Changing the `/api/v1/check_run` response for service checks to be on
par with the datadog api spec as per
https://docs.datadoghq.com/api/latest/service-checks/

This is the same implementation as the PR for the series endpoints
#35744

<!-- Issue number (e.g. #1234) or full URL to issue, if applicable. -->
#### Link to tracking issue

Fixes
#36027

<!--Describe what testing was performed and which tests were added.-->
#### Testing

Unit tests updated and are passing

<!--Describe the documentation added.-->
#### Documentation

Changelog updated
jpbarto pushed a commit to jpbarto/opentelemetry-collector-contrib that referenced this pull request Oct 29, 2024
…SON status: ok (open-telemetry#36029)

<!--Ex. Fixing a bug - Describe the bug and how this fixes the issue.
Ex. Adding a feature - Explain what this achieves.-->
#### Description

Changing the `/api/v1/check_run` response for service checks to be on
par with the datadog api spec as per
https://docs.datadoghq.com/api/latest/service-checks/

This is the same implementation as the PR for the series endpoints
open-telemetry#35744

<!-- Issue number (e.g. open-telemetry#1234) or full URL to issue, if applicable. -->
#### Link to tracking issue

Fixes
open-telemetry#36027

<!--Describe what testing was performed and which tests were added.-->
#### Testing

Unit tests updated and are passing

<!--Describe the documentation added.-->
#### Documentation

Changelog updated
zzhlogin pushed a commit to zzhlogin/opentelemetry-collector-contrib-aws that referenced this pull request Nov 12, 2024
…SON status: ok (open-telemetry#36029)

<!--Ex. Fixing a bug - Describe the bug and how this fixes the issue.
Ex. Adding a feature - Explain what this achieves.-->
#### Description

Changing the `/api/v1/check_run` response for service checks to be on
par with the datadog api spec as per
https://docs.datadoghq.com/api/latest/service-checks/

This is the same implementation as the PR for the series endpoints
open-telemetry#35744

<!-- Issue number (e.g. open-telemetry#1234) or full URL to issue, if applicable. -->
#### Link to tracking issue

Fixes
open-telemetry#36027

<!--Describe what testing was performed and which tests were added.-->
#### Testing

Unit tests updated and are passing

<!--Describe the documentation added.-->
#### Documentation

Changelog updated
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[datadogreceiver] api/v1/series returns OK, instead of JSON status: ok
3 participants