Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add exceptionmetricsprocessor #17271

Closed

Conversation

marctc
Copy link
Contributor

@marctc marctc commented Dec 27, 2022

Description: Added processor to create metrics from recorded exceptions. The implementation
is heavily inspired from spanmetricsprocessor.

Link to tracking Issue: #17272

Note for reviewers: Does it make sense to reuse some of the functions from spanmetricsprocessor that
are duplicated here? Or would it be better to do some refactorings and extract common files/functions in a separate
directory?

Documentation: Added examples in README.

@marctc marctc requested review from a team and Aneurysm9 December 27, 2022 14:00
@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Dec 27, 2022

CLA Signed

The committers listed above are authorized under a signed CLA.

@djaglowski
Copy link
Member

@marctc, thanks for the contribution.

Please read through the guidelines for contributing a component. The most important point is that you'll need to open an issue to propose the component, with the goal of finding a "sponsor" (a maintainer or approver who is willing to co-own the component).

For what it's worth, I think a component like this makes sense, but we will probably want it implemented as a "connector". (See open-telemetry/opentelemetry-collector#6700)

@marctc
Copy link
Contributor Author

marctc commented Dec 27, 2022

@djaglowski thanks for the info! I created the issue here: #17272. I'm reading the contributing guidelines for the mising steps.

@github-actions
Copy link
Contributor

This PR was marked stale due to lack of activity. It will be closed in 14 days.

@github-actions github-actions bot added the Stale label Jan 11, 2023
@github-actions
Copy link
Contributor

Closed as inactive. Feel free to reopen if this PR is still being worked on.

@github-actions github-actions bot closed this Jan 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants