Connectors prototype v3 #6700
Closed
Connectors prototype v3 #6700
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportBase: 89.94% // Head: 90.45% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #6700 +/- ##
==========================================
+ Coverage 89.94% 90.45% +0.51%
==========================================
Files 245 245
Lines 14712 15036 +324
==========================================
+ Hits 13232 13601 +369
+ Misses 1210 1152 -58
- Partials 270 283 +13
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
djaglowski
force-pushed
the
connectors-prototype-v3
branch
3 times, most recently
from
4a06824 to
d824308
Compare
djaglowski
force-pushed
the
connectors-prototype-v3
branch
6 times, most recently
from
67c822c to
bce329b
Compare
djaglowski
force-pushed
the
connectors-prototype-v3
branch
3 times, most recently
from
6ec2777 to
616c255
Compare
djaglowski
force-pushed
the
connectors-prototype-v3
branch
3 times, most recently
from
f59078f to
f2b050a
Compare
|
This PR was marked stale due to lack of activity. It will be closed in 14 days. |
djaglowski
force-pushed
the
connectors-prototype-v3
branch
from
f2b050a to
43dec53
Compare
This was referenced Jan 5, 2023
djaglowski
force-pushed
the
connectors-prototype-v3
branch
from
43dec53 to
990292d
Compare
djaglowski
force-pushed
the
connectors-prototype-v3
branch
2 times, most recently
from
23e69ef to
00b5eff
Compare
djaglowski
force-pushed
the
connectors-prototype-v3
branch
3 times, most recently
from
31aa08b to
a3151bc
Compare
This was referenced Jan 24, 2023
djaglowski
force-pushed
the
connectors-prototype-v3
branch
4 times, most recently
from
24fe801 to
ba6f793
Compare
This was referenced Jan 25, 2023
djaglowski
force-pushed
the
connectors-prototype-v3
branch
4 times, most recently
from
14104ba to
258a5c1
Compare
djaglowski
force-pushed
the
connectors-prototype-v3
branch
from
258a5c1 to
4e4da6d
Compare
djaglowski
force-pushed
the
connectors-prototype-v3
branch
from
4e4da6d to
8fe9053
Compare
|
Closing since we are almost done in #7045 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Variation of #6372, with reduced connector types.
This simplifies code in the core connector packages, but pushes some complexity into individual implementations. In particular, connectors that can consume a signal more than one way must ensure that their constructors set up the proper consume function.