Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for connector configurations #6789

Merged
merged 2 commits into from
Jan 18, 2023
Merged

Add support for connector configurations #6789

merged 2 commits into from
Jan 18, 2023

Conversation

djaglowski
Copy link
Member

Subset of #6700

@codecov
Copy link

codecov bot commented Dec 13, 2022 •
edited
Loading

Codecov Report

Base: 91.01% // Head: 90.96% // Decreases project coverage by -0.05% ⚠️

Coverage data is based on head (8e51f59) compared to base (424bde8).
Patch coverage: 60.86% of modified lines in pull request are covered.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #6789      +/-   ##
==========================================
- Coverage   91.01%   90.96%   -0.05%     
==========================================
  Files         239      239              
  Lines       14399    14421      +22     
==========================================
+ Hits        13105    13118      +13     
- Misses       1042     1048       +6     
- Partials      252      255       +3
Impacted Files Coverage Δ
otelcol/otelcoltest/nop_factories.go 25.00% <0.00%> (-4.42%) ⬇️
cmd/otelcorecol/components.go 61.53% <50.00%> (-2.10%) ⬇️
cmd/builder/internal/builder/config.go 68.67% <72.72%> (+0.18%) ⬆️
service/host.go 89.47% <100.00%> (+1.23%) ⬆️
service/service.go 67.50% <100.00%> (+0.27%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@djaglowski
Copy link
Member Author

Integration test failure addressed in #6797

@djaglowski djaglowski marked this pull request as ready for review December 14, 2022 02:01
@djaglowski djaglowski requested review from a team and Aneurysm9 December 14, 2022 02:01
@djaglowski
Copy link
Member Author

/skipchangelog?

@djaglowski
Copy link
Member Author

cc @bogdandrutu

@bogdandrutu bogdandrutu changed the title Add connectors to configuration of collector Add connectors to configuration of the collector builder Dec 14, 2022
bogdandrutu
bogdandrutu reviewed Dec 14, 2022
View reviewed changes
otelcol/factories.go Outdated Show resolved Hide resolved
@djaglowski djaglowski mentioned this pull request Jan 3, 2023
Closed
@djaglowski djaglowski force-pushed the connector-config branch 3 times, most recently from 8f2de0d to 47b3a55 Compare January 11, 2023 12:26
@djaglowski djaglowski added Skip Changelog PRs that do not require a CHANGELOG.md entry area:connector labels Jan 11, 2023
jpkrohling
jpkrohling reviewed Jan 11, 2023
View reviewed changes
Copy link
Member

@jpkrohling jpkrohling left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. The title is a bit misleading though, as this includes not only changes related to the builder.

Besides, I think this might deserve its own changelog entry, making it explicit that the builder now supports connectors.

@djaglowski djaglowski changed the title Add connectors to configuration of the collector builder Add support for connector configurations Jan 11, 2023
@djaglowski
Copy link
Member Author

Thanks @jpkrohling. I've added a changelog entry and updated the title.

@bogdandrutu bogdandrutu merged commit c251f3d into open-telemetry:main Jan 18, 2023
@djaglowski djaglowski deleted the connector-config branch January 18, 2023 00:48
codeboten pushed a commit to codeboten/opentelemetry-collector that referenced this pull request Jan 23, 2023
@djaglowski
Add support for connector configurations (open-telemetry#6789)
7be8129 
* Add connectors to configuration of collector

* changelog
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bogdandrutu bogdandrutu bogdandrutu left review comments

@Aneurysm9 Aneurysm9 Aneurysm9 left review comments

@TylerHelmuth TylerHelmuth TylerHelmuth approved these changes

@kovrus kovrus kovrus approved these changes

@jpkrohling jpkrohling jpkrohling approved these changes

Assignees
No one assigned
Labels
area:connector Skip Changelog PRs that do not require a CHANGELOG.md entry
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@djaglowski @jpkrohling @Aneurysm9 @bogdandrutu @kovrus @TylerHelmuth