-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add full component graph build #7045
Add full component graph build #7045
Conversation
Codecov ReportBase: 89.40% // Head: 90.58% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #7045 +/- ##
==========================================
+ Coverage 89.40% 90.58% +1.18%
==========================================
Files 293 293
Lines 13999 14240 +241
==========================================
+ Hits 12516 12900 +384
+ Misses 1215 1072 -143
Partials 268 268
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
2aeba98
to
0b8d98d
Compare
26d1a07
to
8236cca
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I forgot to press submit review, I am sorry
f86be6e
to
3578c48
Compare
66f648a
to
6ab3baf
Compare
I think I've addressed all feedback. Most items were addressed in separate commits for the sake of readability. I can squash when you think it's ready. |
6ab3baf
to
fce05a8
Compare
This PR contains the bulk of what remains of #6700
It is a large PR, but mostly because of tests.
I'm presenting this as an alternative to the incremental top-down approach described in #7023. The main benefit of this would be to prevent a temporary lapse in test coverage.