Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[chore] Move component loggers into service/internal/components #6925

Merged
merged 1 commit into from
Jan 11, 2023

Conversation

djaglowski
Copy link
Member

This reduces complexity of service/pipelines.go and can be reused such as in #6700

@codecov
Copy link

codecov bot commented Jan 10, 2023

Codecov Report

Base: 91.05% // Head: 91.12% // Increases project coverage by +0.07% 🎉

Coverage data is based on head (6197cb4) compared to base (7d168dd).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6925      +/-   ##
==========================================
+ Coverage   91.05%   91.12%   +0.07%     
==========================================
  Files         237      238       +1     
  Lines       14298    14412     +114     
==========================================
+ Hits        13019    13133     +114     
  Misses       1027     1027              
  Partials      252      252              
Impacted Files Coverage Δ
connector/connector.go 100.00% <100.00%> (ø)
connector/connectortest/connector.go 100.00% <100.00%> (ø)
service/extensions/extensions.go 77.90% <100.00%> (-0.99%) ⬇️
service/internal/components/components.go 100.00% <100.00%> (ø)
service/internal/components/loggers.go 100.00% <100.00%> (ø)
service/pipelines.go 93.93% <100.00%> (-0.30%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@djaglowski djaglowski marked this pull request as ready for review January 10, 2023 15:45
@djaglowski djaglowski requested review from a team and dmitryax January 10, 2023 15:45
service/internal/components/loggers.go Outdated Show resolved Hide resolved
@bogdandrutu bogdandrutu merged commit ff15c5d into open-telemetry:main Jan 11, 2023
@djaglowski djaglowski deleted the component-loggers branch January 11, 2023 11:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants