Calculate delta instead of rate for cumulative metrics in EMF exporter #2512
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/assign @mxiamxia |
Codecov Report
@@ Coverage Diff @@
## main #2512 +/- ##
==========================================
- Coverage 91.60% 91.59% -0.01%
==========================================
Files 450 450
Lines 22191 22183 -8
==========================================
- Hits 20327 20319 -8
Misses 1394 1394
Partials 470 470
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
bjrara
force-pushed
the
delta_counter
branch
7 times, most recently
from
a3be34d to
c10d724
Compare
bjrara
changed the title
bjrara
changed the title
bjrara
changed the title
bjrara
changed the title
bjrara
changed the title
mxiamxia
reviewed
Mar 9, 2021
|
Is it possible to do the refactoring, moving the files around, first in a PR and followup with the logic change to make it easier to review? |
Split to 2 PRs: #2627 |
bjrara
force-pushed
the
delta_counter
branch
3 times, most recently
from
064f076 to
eaad1bf
Compare
kisieland
referenced
this pull request
in kisieland/opentelemetry-collector-contrib
Mar 16, 2021
Signed-off-by: Bogdan Drutu <bogdandrutu@gmail.com>
anuraaga
reviewed
Mar 18, 2021
bjrara
force-pushed
the
delta_counter
branch
3 times, most recently
from
a75bf4b to
9d4d8f7
Compare
anuraaga
reviewed
Mar 19, 2021
bjrara
force-pushed
the
delta_counter
branch
3 times, most recently
from
eabae34 to
00ebaf0
Compare
Thank you! |
6 tasks
pmatyjasek-sumo
referenced
this pull request
in pmatyjasek-sumo/opentelemetry-collector-contrib
Apr 28, 2021
**Why do we need it?** This is a follow-up PR of open-telemetry#2627. Currently, when cumulative metrics, e.g. counter/summary, come into EMF exporter, the value will be adjusted to rate (in seconds). However, this is not the correct behavior, as what we observed from CloudWatch dashboard, the backend expects delta calculation result. In this PR, we change the rate calculation to delta regarding cumulative metrics.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why do we need it?
This is a follow-up PR of #2627.
Currently, when cumulative metrics, e.g. counter/summary, come into EMF exporter, the value will be adjusted to rate (in seconds). However, this is not the correct behavior, as what we observed from CloudWatch dashboard, the backend expects delta calculation result.
In this PR, we change the rate calculation to delta regarding cumulative metrics.