-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add prometheus type field to EMF exporter for CloudWatch compatibility #2689
Conversation
Codecov Report
@@ Coverage Diff @@
## main #2689 +/- ##
==========================================
+ Coverage 90.53% 91.60% +1.06%
==========================================
Files 444 445 +1
Lines 21984 22073 +89
==========================================
+ Hits 19904 20220 +316
+ Misses 1618 1384 -234
- Partials 462 469 +7
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
@jrcamp , I carefully reviewed this PR and LGTM. Could you please help to review it? |
…2689) Signed-off-by: Bogdan Drutu <bogdandrutu@gmail.com>
Hi @bogdandrutu , could you please help on this PR? Thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mxiamxia I see a pattern of combining refactoring and logic changes into single PRs for this component. Can you help to make sure such changes are separated?
Ah sorry I got confused it looks like this PR contains #2512 - so it means that's a dependency right? |
@anuraaga Sorry about the confusion. I thought review in tandem would make it easier. Re-org the commit. Hope it help. |
Why do we need it?
Currently in CloudWatch agent, a field
prom_metric_type
will be added to CloudWatch log per item when metrics are collected from Prometheus. In order to keep the behavior the same as CloudWatch agent after user migrating to otel collector, we need to add the same field in EMF exporter.