Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update nsxtreceiver to checkapi standards #26509

Merged
merged 11 commits into from
Sep 12, 2023
Merged

Update nsxtreceiver to checkapi standards #26509

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
a31f506
fix exporting of NewMockClient by refactoring to newMockClient
greatestusername Sep 7, 2023
7565fbf
upate allowlist.txt and add changelog
greatestusername Sep 7, 2023
3cc88f3
Merge branch 'open-telemetry:main' into 26304-checkapi-nsxtreceiver
greatestusername Sep 7, 2023
07b65d5
Merge branch 'main' into 26304-checkapi-nsxtreceiver
greatestusername Sep 7, 2023
915d8e0
add note to chlog
greatestusername Sep 7, 2023
fffa3bc
Merge branch '26304-checkapi-nsxtreceiver' of github.com:greatestuser…
greatestusername Sep 7, 2023
bd260bb
remove changelog as the change is only in tests and non-breaking
greatestusername Sep 7, 2023
19a02c6
Merge branch 'main' into 26304-checkapi-nsxtreceiver
greatestusername Sep 8, 2023
5374476
Merge branch 'main' into 26304-checkapi-nsxtreceiver
greatestusername Sep 8, 2023
d75669b
Merge branch 'main' into 26304-checkapi-nsxtreceiver
greatestusername Sep 11, 2023
b623ac5
Merge branch 'main' into 26304-checkapi-nsxtreceiver
greatestusername Sep 11, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion cmd/checkapi/allowlist.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,6 @@ receiver/kafkareceiver
receiver/mongodbatlasreceiver
receiver/mongodbreceiver
receiver/mysqlreceiver
receiver/nsxtreceiver
receiver/podmanreceiver
receiver/pulsarreceiver
receiver/windowseventlogreceiver
4 changes: 2 additions & 2 deletions receiver/nsxtreceiver/client_mock_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -132,8 +132,8 @@ func (m *MockClient) TransportNodes(ctx context.Context) ([]model.TransportNode,
return r0, r1
}

// NewMockClient creates a new instance of MockClient. It also registers the testing.TB interface on the mock and a cleanup function to assert the mocks expectations.
func NewMockClient(t testing.TB) *MockClient {
// newMockClient creates a new instance of MockClient. It also registers the testing.TB interface on the mock and a cleanup function to assert the mocks expectations.
func newMockClient(t testing.TB) *MockClient {
mock := &MockClient{}
mock.Mock.Test(t)

Expand Down
6 changes: 3 additions & 3 deletions receiver/nsxtreceiver/scraper_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ import (
)

func TestScrape(t *testing.T) {
mockClient := NewMockClient(t)
mockClient := newMockClient(t)

mockClient.On("ClusterNodes", mock.Anything).Return(loadTestClusterNodes())
mockClient.On("TransportNodes", mock.Anything).Return(loadTestTransportNodes())
Expand Down Expand Up @@ -68,7 +68,7 @@ func TestScrape(t *testing.T) {
}

func TestScrapeTransportNodeErrors(t *testing.T) {
mockClient := NewMockClient(t)
mockClient := newMockClient(t)
mockClient.On("TransportNodes", mock.Anything).Return(nil, errUnauthorized)
scraper := newScraper(
&Config{
Expand All @@ -84,7 +84,7 @@ func TestScrapeTransportNodeErrors(t *testing.T) {
}

func TestScrapeClusterNodeErrors(t *testing.T) {
mockClient := NewMockClient(t)
mockClient := newMockClient(t)

mockClient.On("ClusterNodes", mock.Anything).Return(nil, errUnauthorized)
mockClient.On("TransportNodes", mock.Anything).Return(loadTestTransportNodes())
Expand Down