Update nsxtreceiver to checkapi standards #26509
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
greatestusername
changed the title
…name/opentelemetry-collector-contrib into 26304-checkapi-nsxtreceiver
atoulme
reviewed
Sep 7, 2023
| # Use this changelog template to create an entry for release notes. | ||
|
|
||
| # One of 'breaking', 'deprecation', 'new_component', 'enhancement', 'bug_fix' | ||
| change_type: breaking |
There was a problem hiding this comment.
since this is test code, it's not considered a breaking change, and you can delete the changelog entry. I'll mark this PR as "Skip Changelog". Changes look good otherwise.
There was a problem hiding this comment.
Ah good point! Thank you! Will do
There was a problem hiding this comment.
is this enhancement or bug_fix or does it even matter?
There was a problem hiding this comment.
You can simply remove this file since it's a test-only change.
There was a problem hiding this comment.
oh gotcha. Yeah that was in the sentence sure enough... Some days... 🧠
44 tasks
atoulme
approved these changes
Sep 7, 2023
songy23
approved these changes
Sep 7, 2023
atoulme
added
the
ready to merge
schmikei
approved these changes
Sep 11, 2023
codeboten
approved these changes
Sep 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
stop exporting
NewMockClientmethod to align with checkapi standards as related to issue #26304Link to tracking Issue: #26304
Testing:
go run cmd/checkapi/main.go .
go test for nsxtreceiver
Documentation: no changes