Update nsxtreceiver to checkapi standards

.chloggen/26304-checkapi-nsxtreceiver.yaml

@@ -0,0 +1,27 @@
+# Use this changelog template to create an entry for release notes.
+
+# One of 'breaking', 'deprecation', 'new_component', 'enhancement', 'bug_fix'
+change_type: breaking
+
+# The name of the component, or a single word describing the area of concern, (e.g. filelogreceiver)
+component: nsxtreceiver
+
+# A brief description of the change.  Surround your text with quotes ("") if it needs to start with a backtick (`).
+note: do not export `NewMockClient`
+
+# Mandatory: One or more tracking issues related to the change. You can use the PR number here if no issue exists.
+issues: [26304]
+
+# (Optional) One or more lines of additional information to render under the primary note.
+# These lines will be padded with 2 spaces and then inserted directly into the document.
+# Use pipe (|) for multiline entries.
+subtext:
+
+# If your change doesn't affect end users or the exported elements of any package,
+# you should instead start your pull request title with [chore] or use the "Skip Changelog" label.
+# Optional: The change log or logs in which this entry should be included.
+# e.g. '[user]' or '[user, api]'
+# Include 'user' if the change is relevant to end users.
+# Include 'api' if there is a change to a library API.
+# Default: '[user]'
+change_logs: [api]

cmd/checkapi/allowlist.txt

@@ -31,7 +31,6 @@ receiver/kafkareceiver
 receiver/mongodbatlasreceiver
 receiver/mongodbreceiver
 receiver/mysqlreceiver
-receiver/nsxtreceiver
 receiver/podmanreceiver
 receiver/pulsarreceiver
 receiver/windowseventlogreceiver

receiver/nsxtreceiver/client_mock_test.go

@@ -132,8 +132,8 @@ func (m *MockClient) TransportNodes(ctx context.Context) ([]model.TransportNode,
 	return r0, r1
 }
 
-// NewMockClient creates a new instance of MockClient. It also registers the testing.TB interface on the mock and a cleanup function to assert the mocks expectations.
-func NewMockClient(t testing.TB) *MockClient {
+// newMockClient creates a new instance of MockClient. It also registers the testing.TB interface on the mock and a cleanup function to assert the mocks expectations.
+func newMockClient(t testing.TB) *MockClient {
 	mock := &MockClient{}
 	mock.Mock.Test(t)
 

receiver/nsxtreceiver/scraper_test.go

@@ -25,7 +25,7 @@ import (
 )
 
 func TestScrape(t *testing.T) {
-	mockClient := NewMockClient(t)
+	mockClient := newMockClient(t)
 
 	mockClient.On("ClusterNodes", mock.Anything).Return(loadTestClusterNodes())
 	mockClient.On("TransportNodes", mock.Anything).Return(loadTestTransportNodes())
@@ -68,7 +68,7 @@ func TestScrape(t *testing.T) {
 }
 
 func TestScrapeTransportNodeErrors(t *testing.T) {
-	mockClient := NewMockClient(t)
+	mockClient := newMockClient(t)
 	mockClient.On("TransportNodes", mock.Anything).Return(nil, errUnauthorized)
 	scraper := newScraper(
 		&Config{
@@ -84,7 +84,7 @@ func TestScrapeTransportNodeErrors(t *testing.T) {
 }
 
 func TestScrapeClusterNodeErrors(t *testing.T) {
-	mockClient := NewMockClient(t)
+	mockClient := newMockClient(t)
 
 	mockClient.On("ClusterNodes", mock.Anything).Return(nil, errUnauthorized)
 	mockClient.On("TransportNodes", mock.Anything).Return(loadTestTransportNodes())