Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[processor/resourcedetection] Add feature gate to change family and model to string #29152

Merged
merged 3 commits into from
Nov 13, 2023

Conversation

mx-psi
Copy link
Member

@mx-psi mx-psi commented Nov 13, 2023

Description:

Add feature gate to change family and CPU model to string, to adapt to open-telemetry/semantic-conventions/issues/495.

Link to tracking Issue: Fixes #29025

Testing: Tested with the sample configuration on #26533.

@mx-psi
Copy link
Member Author

mx-psi commented Nov 13, 2023

cc @povilasv @ChrsMark

Copy link
Member

@ChrsMark ChrsMark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank's for covering this! The change LGTM.

@songy23 songy23 added the ready to merge Code review completed; ready to merge by maintainers label Nov 13, 2023
@mx-psi mx-psi merged commit 39878d2 into open-telemetry:main Nov 13, 2023
88 checks passed
@github-actions github-actions bot added this to the next release milestone Nov 13, 2023
RoryCrispin pushed a commit to ClickHouse/opentelemetry-collector-contrib that referenced this pull request Nov 24, 2023
…odel to string (open-telemetry#29152)

**Description:** 

Add feature gate to change family and CPU model to string, to adapt to
open-telemetry/semantic-conventions/issues/495.

**Link to tracking Issue:** Fixes open-telemetry#29025

**Testing:** Tested with the sample configuration on open-telemetry#26533.
mx-psi added a commit that referenced this pull request Nov 30, 2023
…ostCPUModelAndFamilyAsString` to beta (#29462)

**Description:** 

Follow up to #29152. The feature gate has been in alpha for two releases
(v0.89.0 and v0.90.0).

**Link to tracking Issue:** Relates to #29025 and to
open-telemetry/semantic-conventions/issues/495.

**Testing:** Tested with the sample configuration on #26533.
mx-psi added a commit that referenced this pull request May 17, 2024
…PUModelAndFamilyAsString` feature gate to stable (#33077)

**Description:** <Describe what has changed.>
<!--Ex. Fixing a bug - Describe the bug and how this fixes the issue.
Ex. Adding a feature - Explain what this achieves.-->

Follows #29152 and #29462. The feature gate has been in beta since
v0.91.0.

**Link to tracking Issue:** Relates to
#29025
and to
open-telemetry/semantic-conventions#495
mx-psi pushed a commit that referenced this pull request Sep 16, 2024
…CPUModelAndFamilyAsString feature gate (#35203)

Description:

Follows #33077,
#29152
and
#29462.
The feature gate has been stable since v0.101.0.

Link to tracking Issue: Relates to
#29025
and to
open-telemetry/semantic-conventions#495


/cc @mx-psi

---------

Signed-off-by: ChrsMark <chrismarkou92@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
processor/resourcedetection Resource detection processor ready to merge Code review completed; ready to merge by maintainers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[processor/resourcedetection] failed to convert cpuinfo family to integer
5 participants