Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

host.cpu.family and host.cpu.model.id should be strings #495

Closed
mx-psi opened this issue Nov 8, 2023 · 0 comments · Fixed by #499
Closed

host.cpu.family and host.cpu.model.id should be strings #495

mx-psi opened this issue Nov 8, 2023 · 0 comments · Fixed by #499
Assignees
@joaopgrassi

Comments

@mx-psi
Copy link
Member

mx-psi commented Nov 8, 2023

Based on open-telemetry/opentelemetry-collector-contrib/issues/29025, for some processor families (see linked issue) it seems like the CPU familiy and the CPU model are not integers (integers are used for Intel and AMD, but not e.g. PowerPC).

We should change the type to string. This is a breaking change that has no way to be expressed on the telemetry schema.
@mx-psi mx-psi mentioned this issue Nov 8, 2023
Closed
@mx-psi mx-psi changed the title host.cpu.family and host.cpu.model should be strings host.cpu.family and host.cpu.model.id should be strings Nov 9, 2023
@mx-psi mx-psi mentioned this issue Nov 9, 2023
Merged
3 tasks
@mx-psi mx-psi mentioned this issue Nov 13, 2023
Merged
mx-psi added a commit to open-telemetry/opentelemetry-collector-contrib that referenced this issue Nov 13, 2023
@mx-psi
[processor/resourcedetection] Add feature gate to change family and m…
39878d2 
…odel to string (#29152)

**Description:** 

Add feature gate to change family and CPU model to string, to adapt to
open-telemetry/semantic-conventions/issues/495.

**Link to tracking Issue:** Fixes #29025

**Testing:** Tested with the sample configuration on #26533.
@mx-psi mx-psi mentioned this issue Nov 23, 2023
Merged
RoryCrispin pushed a commit to ClickHouse/opentelemetry-collector-contrib that referenced this issue Nov 24, 2023
@mx-psi @RoryCrispin
[processor/resourcedetection] Add feature gate to change family and m…
5bed58b 
…odel to string (open-telemetry#29152)

**Description:** 

Add feature gate to change family and CPU model to string, to adapt to
open-telemetry/semantic-conventions/issues/495.

**Link to tracking Issue:** Fixes open-telemetry#29025

**Testing:** Tested with the sample configuration on open-telemetry#26533.
mx-psi added a commit to open-telemetry/opentelemetry-collector-contrib that referenced this issue Nov 30, 2023
@mx-psi
[processor/resourcedetection] Graduate `processor.resourcedetection.h…
73747ae 
…ostCPUModelAndFamilyAsString` to beta (#29462)

**Description:** 

Follow up to #29152. The feature gate has been in alpha for two releases
(v0.89.0 and v0.90.0).

**Link to tracking Issue:** Relates to #29025 and to
open-telemetry/semantic-conventions/issues/495.

**Testing:** Tested with the sample configuration on #26533.
@mx-psi mx-psi mentioned this issue Jan 23, 2024
Closed
@mx-psi mx-psi mentioned this issue Feb 8, 2024
Closed
@mx-psi mx-psi mentioned this issue May 15, 2024
Merged
mx-psi added a commit to open-telemetry/opentelemetry-collector-contrib that referenced this issue May 17, 2024
@mx-psi
[processor/resourcedetection] Move `processor.resourcedetection.hostC…
c8a2369 
…PUModelAndFamilyAsString` feature gate to stable (#33077)

**Description:** <Describe what has changed.>
<!--Ex. Fixing a bug - Describe the bug and how this fixes the issue.
Ex. Adding a feature - Explain what this achieves.-->

Follows #29152 and #29462. The feature gate has been in beta since
v0.91.0.

**Link to tracking Issue:** Relates to
#29025
and to
open-telemetry/semantic-conventions#495
@ChrsMark ChrsMark mentioned this issue Sep 16, 2024
Merged
mx-psi pushed a commit to open-telemetry/opentelemetry-collector-contrib that referenced this issue Sep 16, 2024
@ChrsMark
[processor/resourcedetection] Remove processor.resourcedetection.host…
1b03346 
…CPUModelAndFamilyAsString feature gate (#35203)

Description:

Follows #33077,
#29152
and
#29462.
The feature gate has been stable since v0.101.0.

Link to tracking Issue: Relates to
#29025
and to
open-telemetry/semantic-conventions#495


/cc @mx-psi

---------

Signed-off-by: ChrsMark <chrismarkou92@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@joaopgrassi joaopgrassi

Labels
None yet
Projects
System Semantic Convention Working Group
Archived in project
Milestone
No milestone
2 participants
@mx-psi @joaopgrassi