-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[receiver/hostmetrics] Deprecate processesscraper #30894
[receiver/hostmetrics] Deprecate processesscraper #30894
Conversation
This commit deprecates the processesscraper in favour of adding the functionality to the processscraper.
82dd1b4
to
4249401
Compare
Since this receiver is in beta, I should not have directly been making a deprecation in this PR. Instead this PR will be focused on adding the functionality to the `processscraper` and provides a warning suggestion to the `processesscraper` instead of directly declaring it deprecated.
receiver/hostmetricsreceiver/internal/scraper/processesscraper/processes_scraper.go
Show resolved
Hide resolved
receiver/hostmetricsreceiver/internal/scraper/processscraper/process_scraper.go
Show resolved
Hide resolved
The guard in scrapeAndAppendSystemProcessesCreated metric was already covered by the record data point function.
* Add system.processes.* metrics to allowed metrics in duplicate metrics validation test * Change ctx arg to _ in certain functions * Change type name to Scraper in processesscraper fallback
Fixed a misname in the fallback build for aggregate process data, run gci on the aggregate_process files.
As discussed on the System Semantic Conventions SIG, we want to have a way to disable all metrics in particular group. It's needed if users don't have the |
This PR was marked stale due to lack of activity. It will be closed in 14 days. |
Closed as inactive. Feel free to reopen if this PR is still being worked on. |
Description:
This PR deprecates the
processesscraper
in favour of adding the functionality to theprocessscraper
.Link to tracking Issue:
#30895
Testing:
I wrote all testing with explanations in https://gist.github.com/braydonk/124f4242299a8cb03f44c55b056450e1
Documentation:
I added a note to the
hostmetricsreceiver
README and generated new docs forprocessscraper
.