Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[cmd/mdatagen] Add DefaultMetricsBuilderConfigAllDisabled #30995

Closed
wants to merge 1 commit into from

Conversation

braydonk
Copy link
Contributor

@braydonk braydonk commented Feb 1, 2024

Description:
Adds a new function to config.go.tmpl that will generate a new function to provide a MetricsBuilder config with all available metrics disabled.

Link to tracking Issue:
#30993

Testing:
Regenerated in this module to show an example of the generation. I also did this originally in #30894 and it worked well there, but I pulled it out in favour of opening it as a separate PR here.

Documentation:
I'm not sure if there is any, but if there's something I missed I'm happy to add it.

Adds a new function to config.go.tmpl that will generate a new function
to provide a MetricsBuilder config with all available metrics disabled.
@braydonk braydonk requested a review from dmitryax as a code owner February 1, 2024 13:37
@braydonk braydonk requested a review from a team February 1, 2024 13:37
@braydonk braydonk changed the title Add DefaultMetricsBuilderConfigAllDisabled [cmd/mdatagen] Add DefaultMetricsBuilderConfigAllDisabled Feb 1, 2024
@github-actions github-actions bot added the cmd/mdatagen mdatagen command label Feb 1, 2024
Copy link
Contributor

This PR was marked stale due to lack of activity. It will be closed in 14 days.

Copy link
Contributor

github-actions bot commented Mar 1, 2024

Closed as inactive. Feel free to reopen if this PR is still being worked on.

@github-actions github-actions bot closed this Mar 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cmd/mdatagen mdatagen command Stale
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants