Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add k8s makefile targets #32349

Merged
merged 2 commits into from
May 22, 2024
Merged

Conversation

ChrsMark
Copy link
Member

@ChrsMark ChrsMark commented Apr 12, 2024

Description:

First attempt for #32348.

Link to tracking Issue: #32348

Testing:

Documentation:

@crobert-1 crobert-1 added Skip Changelog PRs that do not require a CHANGELOG.md entry comp:kubernetes Kubernetes-related components labels Apr 12, 2024
@ChrsMark ChrsMark marked this pull request as ready for review April 26, 2024 13:39
@ChrsMark ChrsMark requested review from a team and andrzej-stencel April 26, 2024 13:39
@andrzej-stencel
Copy link
Member

I agree it's useful, but perhaps worth adding a little documentation, perhaps in the examples/kubernetes/README.md file, an example on how to use these kind make targets?

@ChrsMark
Copy link
Member Author

Good idea @andrzej-stencel! I wonder though if this place is the best to host such a developer docs files 🤔 If that's our best option here, I can add new md file in this directory called dev-docs.md cause I think the README.md one seems to be related to the logs specific example?

@andrzej-stencel
Copy link
Member

Good idea @andrzej-stencel! I wonder though if this place is the best to host such a developer docs files 🤔 If that's our best option here, I can add new md file in this directory called dev-docs.md cause I think the README.md one seems to be related to the logs specific example?

Sure, let's add the docs whenever you see fit, the important thing is to get it in. We can move it around later if we want. It doesn't need to be well cooked either, I think "quick & dirty" is good for starters too. It's not like it's a product we have to maintain afterwards. 🙂

ChrsMark added 2 commits May 22, 2024 12:42
Signed-off-by: ChrsMark <chrismarkou92@gmail.com>
Signed-off-by: ChrsMark <chrismarkou92@gmail.com>
@ChrsMark
Copy link
Member Author

@andrzej-stencel, thank's for the feedback here. I have added the respective docs. Let me know what you think.

note: if we land this for now I'm planing on adding additional targets (in follow-up PRs) for the deployment mode as well.

@andrzej-stencel andrzej-stencel merged commit 54b25f7 into open-telemetry:main May 22, 2024
162 checks passed
@github-actions github-actions bot added this to the next release milestone May 22, 2024
andrzej-stencel added a commit that referenced this pull request May 30, 2024
…yment (#33220)

**Description:** <Describe what has changed.>
<!--Ex. Fixing a bug - Describe the bug and how this fixes the issue.
Ex. Adding a feature - Explain what this achieves.-->
This PR adds a makefile target for installing a locally built collector
image (on a local k8s kind cluster) in deployment mode.

**Link to tracking Issue:** <Issue number if applicable> 
Fixes
#32348
Follow up of
#32349

**Testing:** <Describe what testing was performed and which tests were
added.>

**Documentation:** <Describe the documentation added.> Added

/cc @andrzej-stencel who reviewed the daemonset target PR

---------

Signed-off-by: ChrsMark <chrismarkou92@gmail.com>
Co-authored-by: Andrzej Stencel <andrzej.stencel@elastic.co>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
comp:kubernetes Kubernetes-related components Skip Changelog PRs that do not require a CHANGELOG.md entry
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants