-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add k8s makefile targets #32349
Add k8s makefile targets #32349
Conversation
I agree it's useful, but perhaps worth adding a little documentation, perhaps in the examples/kubernetes/README.md file, an example on how to use these kind make targets? |
Good idea @andrzej-stencel! I wonder though if this place is the best to host such a developer docs files 🤔 If that's our best option here, I can add new md file in this directory called |
Sure, let's add the docs whenever you see fit, the important thing is to get it in. We can move it around later if we want. It doesn't need to be well cooked either, I think "quick & dirty" is good for starters too. It's not like it's a product we have to maintain afterwards. 🙂 |
Signed-off-by: ChrsMark <chrismarkou92@gmail.com>
Signed-off-by: ChrsMark <chrismarkou92@gmail.com>
@andrzej-stencel, thank's for the feedback here. I have added the respective docs. Let me know what you think. note: if we land this for now I'm planing on adding additional targets (in follow-up PRs) for the |
…yment (#33220) **Description:** <Describe what has changed.> <!--Ex. Fixing a bug - Describe the bug and how this fixes the issue. Ex. Adding a feature - Explain what this achieves.--> This PR adds a makefile target for installing a locally built collector image (on a local k8s kind cluster) in deployment mode. **Link to tracking Issue:** <Issue number if applicable> Fixes #32348 Follow up of #32349 **Testing:** <Describe what testing was performed and which tests were added.> **Documentation:** <Describe the documentation added.> Added /cc @andrzej-stencel who reviewed the daemonset target PR --------- Signed-off-by: ChrsMark <chrismarkou92@gmail.com> Co-authored-by: Andrzej Stencel <andrzej.stencel@elastic.co>
Description:
First attempt for #32348.
Link to tracking Issue: #32348
Testing:
Documentation: