[chore] add Makefile target for installing the collector as k8s deployment #33220
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ChrsMark
changed the title
Signed-off-by: ChrsMark <chrismarkou92@gmail.com>
ChrsMark
force-pushed
the
add_deployment_k8s_makefile_targets
branch
from
b478b77 to
1a30d9e
Compare
Co-authored-by: Andrzej Stencel <andrzej.stencel@elastic.co>
|
Seems worthy of a changelog? |
Hmm, thinking that it's not a user facing change but just a "dev-tools" enhancement I guess no? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
This PR adds a makefile target for installing a locally built collector image (on a local k8s kind cluster) in deployment mode.
Link to tracking Issue:
Fixes #32348
Follow up of #32349
Testing:
Documentation: Added
/cc @andrzej-stencel who reviewed the daemonset target PR