[chore] start and stop otlp exporter once #32809
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
songy23
approved these changes
May 2, 2024
crobert-1
approved these changes
May 2, 2024
Co-authored-by: Yang Song <songy23@users.noreply.github.com>
codeboten
reviewed
May 2, 2024
| if err = bor.metricsReceiver.Start(context.Background(), componenttest.NewNopHost()); err != nil { | ||
| return err | ||
| } | ||
| // we reuse the receiver across signals. Starting the log receiver starts the metrics and traces receiver. |
There was a problem hiding this comment.
This is confusing, do we need the three factory calls above then?
There was a problem hiding this comment.
you need them to set the logs, metrics and traces consumer.
codeboten
approved these changes
May 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The testbed starts and stops the exporter once per signal, but we know it's the same exporter underneath.
This PR changes the behavior of testbed to start and stop the exporter just once. This change is needed to support open-telemetry/opentelemetry-collector#10059