-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Declare how to share a receiver across multiple signals with factory options #10059
Conversation
2e2129a
to
b91efbd
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #10059 +/- ##
==========================================
- Coverage 91.87% 91.59% -0.28%
==========================================
Files 360 359 -1
Lines 16725 16722 -3
==========================================
- Hits 15366 15317 -49
- Misses 1021 1069 +48
+ Partials 338 336 -2 ☔ View full report in Codecov by Sentry. |
3ca6453
to
882df6c
Compare
open-telemetry/opentelemetry-collector-contrib#32809 is open to fix contrib. |
ab33d83
to
5ae1cc8
Compare
There are two behaviors related to status reporting that were implemented in
The solutions currently part of |
The testbed starts and stops the exporter once per signal, but we know it's the same exporter underneath. This PR changes the behavior of testbed to start and stop the exporter just once. This change is needed to support open-telemetry/opentelemetry-collector#10059 --------- Co-authored-by: Alex Boten <223565+codeboten@users.noreply.github.com> Co-authored-by: Yang Song <songy23@users.noreply.github.com>
This PR was marked stale due to lack of activity. It will be closed in 14 days. |
@mwear can we create an integration test that faithfully checks both scenarios you describe? This way we can make sure this continues to work. |
Sure thing. That's an oversight from the original implementation. |
This PR was marked stale due to lack of activity. It will be closed in 14 days. |
@atoulme, sorry for the delay. I looked into this today and the two cases I describe are in fact tested by an existing test case: opentelemetry-collector/internal/sharedcomponent/sharedcomponent_test.go Lines 182 to 273 in 65d59d1
|
This PR was marked stale due to lack of activity. It will be closed in 14 days. |
This PR was marked stale due to lack of activity. It will be closed in 14 days. |
This PR was marked stale due to lack of activity. It will be closed in 14 days. |
5ae1cc8
to
4468a2f
Compare
This PR was marked stale due to lack of activity. It will be closed in 14 days. |
This PR was marked stale due to lack of activity. It will be closed in 14 days. |
Closed as inactive. Feel free to reopen if this PR is still being worked on. |
Description
Declare how to share a receiver across multiple signals with factory options.
Right now, we have each component looking to reuse across signals use a library under internal/sharedcomponent, and declare their own map of components. We move this map to the factory and use a factory option to set a consumer of a different signal on the existing receiver.
This removes the need to declare and manage
internal/sharedcomponent
.This PR lacks test coverage and is meant to collect feedback on the feasibility.
Testing
WIP
Documentation
API docs added.