Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for logs in cloudfoundryreceiver #33044

Conversation

jriguera
Copy link
Contributor

@jriguera jriguera commented May 14, 2024

Description:

Adding support receive logs from Cloudfoundry.

Link to tracking Issue: #32671

Testing: Basic testing inline with the current tests

Documentation:

  • Add new section for logs and their attributes.
  • Update behaviour of ShardID property (rlp_gateway.shard_id).

cc @CemDK @m1rp

CemDK and others added 16 commits May 2, 2024 16:11
… config

Co-authored-by: Jose Riguera <jose.riguera@springer.com>
Co-authored-by: Sam Clulow <sam.clulow@springernature.com>
…ogs to the receiver

Co-authored-by: Jose Riguera <jose.riguera@springer.com>
Co-authored-by: Sam Clulow <sam.clulow@springernature.com>
Co-authored-by: Cem Deniz Kabakci <cem.kabakci@springer.com>
Co-authored-by: Cem Deniz Kabakci <cem.kabakci@springer.com>
Co-authored-by: Jose Riguera <jose.riguera@springer.com>
… tests (now part of config tests). Fix parameters for test function

Co-authored-by: Cem Deniz Kabakci <cem.kabakci@springer.com>
… to now, instead of when the receiver starts

Co-authored-by: Jose Riguera <jose.riguera@springer.com>
…id and span id from RTR Logs

Co-authored-by: Jose Riguera <jose.riguera@springer.com>
Co-authored-by: Jose Riguera <jose.riguera@springer.com>
…velopment

Co-authored-by: Sam Clulow <sam.clulow@springernature.com>
Co-authored-by: Cem Deniz Kabakci <cem.kabakci@springer.com>
Co-authored-by: Sam Clulow <sam.clulow@springernature.com>
Co-authored-by: Cem Deniz Kabakci <cem.kabakci@springer.com>
Co-authored-by: Sam Clulow <sam.clulow@springernature.com>
Co-authored-by: Cem Deniz Kabakci <cem.kabakci@springer.com>
Co-authored-by: Sam Clulow <sam.clulow@springernature.com>
Co-authored-by: Cem Deniz Kabakci <cem.kabakci@springer.com>
Copy link

linux-foundation-easycla bot commented May 14, 2024

CLA Signed

The committers listed above are authorized under a signed CLA.

Copy link
Member

@crobert-1 crobert-1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR, hope my feedback is helpful!

receiver/cloudfoundryreceiver/receiver.go Outdated Show resolved Hide resolved
receiver/cloudfoundryreceiver/receiver.go Outdated Show resolved Hide resolved
receiver/cloudfoundryreceiver/converter.go Show resolved Hide resolved
receiver/cloudfoundryreceiver/converter.go Outdated Show resolved Hide resolved
receiver/cloudfoundryreceiver/converter.go Outdated Show resolved Hide resolved
receiver/cloudfoundryreceiver/receiver.go Outdated Show resolved Hide resolved
receiver/cloudfoundryreceiver/receiver.go Outdated Show resolved Hide resolved
receiver/cloudfoundryreceiver/receiver.go Outdated Show resolved Hide resolved
receiver/cloudfoundryreceiver/stream.go Outdated Show resolved Hide resolved
@crobert-1
Copy link
Member

@CemDK Can you please sign the CLA?

@CemDK
Copy link
Contributor

CemDK commented May 16, 2024

@CemDK Can you please sign the CLA?

Done!
Thanks for the feedback

jriguera and others added 6 commits May 23, 2024 15:06
…R log lines extracting fields and add tests

Co-authored-by: Cem Deniz Kabakci <cem.kabakci@springer.com>
…e telemetryType from cloudFoundryReceiver struct

Co-authored-by: Cem Deniz Kabakci <cem.kabakci@springer.com>
Co-authored-by: Cem Deniz Kabakci <cem.kabakci@springer.com>
* Original CreateStream fucntion was returning a tuple `(loggregator.EnvelopeStream, error)`, but error was always nil, because the upstream funcion from loggregator `rgc.rlpGatewayClient.Stream` does not fail.
* No need to check the error in tests and in the receiver (it was always nil)
* CreateStream splitted in 2 funcions, each applies the filters each one needs, no need to pass aditional parameters to select filters.
@crobert-1 crobert-1 added the ready to merge Code review completed; ready to merge by maintainers label Jun 13, 2024
Copy link
Contributor

@codeboten codeboten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall the change looks good, just one question regarding the new validation

receiver/cloudfoundryreceiver/config.go Show resolved Hide resolved
receiver/cloudfoundryreceiver/doc.go Outdated Show resolved Hide resolved
@TylerHelmuth
Copy link
Member

Code owners @agoallikmaa @pellared please review

@TylerHelmuth
Copy link
Member

NVM I missed the emeritus status.

@TylerHelmuth TylerHelmuth removed the ready to merge Code review completed; ready to merge by maintainers label Jul 1, 2024
@TylerHelmuth
Copy link
Member

@jriguera please get the latest from main

@jriguera
Copy link
Contributor Author

jriguera commented Jul 2, 2024

@jriguera please get the latest from main

@TylerHelmuth done!

@jriguera
Copy link
Contributor Author

jriguera commented Jul 2, 2024

Fixing the tests

jriguera and others added 3 commits July 2, 2024 15:14
…for loop

Co-authored-by: Sam Clulow <sam.clulow@springernature.com>
Co-authored-by: Cem Deniz Kabakci <cem.kabakci@springer.com>
Co-authored-by: Tomas Mota <tomas.mota@springernature.com>
@crobert-1 crobert-1 added the ready to merge Code review completed; ready to merge by maintainers label Jul 2, 2024
jriguera and others added 2 commits July 3, 2024 10:34
Co-authored-by: Alex Boten <223565+codeboten@users.noreply.github.com>
@andrzej-stencel andrzej-stencel merged commit 5356c9d into open-telemetry:main Jul 3, 2024
154 checks passed
@github-actions github-actions bot added this to the next release milestone Jul 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready to merge Code review completed; ready to merge by maintainers receiver/cloudfoundry
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants