[chore] Update tests for confmap strict type change #34027
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TylerHelmuth
requested review from
djaglowski,
jpkrohling,
jmacd,
mx-psi,
songy23 and
fatsheep9146
as code owners
github-actions
bot
added
connector/failover
exporter/datadog
github-actions
bot
requested review from
akats7,
ankitpatel96,
dineshg13,
liustanley,
mackjmr,
StefanKurek and
tamir-michaeli
codeboten
approved these changes
Jul 10, 2024
codeboten
reviewed
Jul 10, 2024
| @@ -4,7 +4,7 @@ receivers: | |||
| processors: | |||
|
|
|||
| probabilistic_sampler/traces: | |||
| sampling_percentage: +Inf | |||
| sampling_percentage: 999_999_999_999_999_999_999_999_999_999_999_999_999 | |||
There was a problem hiding this comment.
is +Inf no longer supported?
There was a problem hiding this comment.
I wasn't able to find a way to get it interpreted as a float. I tried !!float +Inf and got this error message:
cannot resolve the configuration: cannot retrieve the configuration: yaml: cannot decode !!str `+Inf` as a !!float
There was a problem hiding this comment.
From https://yaml.org/spec/1.2.2/#1032-tag-resolution, +.Inf should work
| @@ -1,7 +1,8 @@ | |||
| failover: | |||
|
|
|||
| failover/default: | |||
| priority_levels: [traces] | |||
| priority_levels: | |||
| - [traces] | |||
There was a problem hiding this comment.
should this be - traces?
There was a problem hiding this comment.
The field is a [][]
songy23
approved these changes
Jul 10, 2024
dmitryax
approved these changes
Jul 10, 2024
crobert-1
approved these changes
Jul 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make room for open-telemetry/opentelemetry-collector#10554