Add Azure Resource Logs translator #34830
Conversation
…tor-contrib into azureeventhub_otelsc # Conflicts: # receiver/azureeventhubreceiver/go.mod # receiver/azureeventhubreceiver/go.sum
|
I'm a little unsure why both the changelog is failing: and why the receiver is failing with a missing go.sum entry Any help would be appreciated 😄 |
|
@MikeGoldsmith I would remove the '[user]' from your change log entry and see if it fixes the issue since it says it's the default value anyway. I'll also look into the go mod issue, although I always struggle with those too! |
|
single quotes around your array makes it a string |
|
@MikeGoldsmith I submitted a PR to your fork to try and address some of the build issues. |
|
Thank you @cparkins, I'll take a look shortly. |
Co-authored-by: Alex Boten <223565+codeboten@users.noreply.github.com>
…elemetry-collector-contrib into azureeventhub_otelsc
TylerHelmuth
added
the
ready to merge
TylerHelmuth
removed
the
ready to merge
|
Hey @MikeGoldsmith , Sorry for the late reply. It seems i've missed some updates. I believe it would be a good in next step to introduce the possibility to enable corrections to JSON string so that it would be possible to apply semantic conventions translation. We do it unconditionally in our implementation (you can check it in this commit). I agree, It's not the best approach. It worth to add some extra logic to make it optional and keep the There is also another commit with the time convertion approach. I would like to create a PR with these changes for the both |
**Description**: This PR adds a new Azure Resource Logs translator that can be used to convert Azure events into resource logs events using Semantic conventions defined here [here](https://github.com/open-telemetry/semantic-conventions/blob/main/docs/azure/events.md). This supersedes following draft PR by updating it to have the latest semconv: - open-telemetry#32486 *Note*: A follow-up PR will update the Azure receiver to use the new translator. **Testing**: Includes unit tests to verify expected behaviours and data structures. **Documentation**: --- cc @markrendle @lmolkova @TylerHelmuth --------- Signed-off-by: Alex Boten <223565+codeboten@users.noreply.github.com> Co-authored-by: Mark Rendle <mark@rendlelabs.com> Co-authored-by: Alex Boten <223565+codeboten@users.noreply.github.com> Co-authored-by: Curtis Robert <crobert@splunk.com> Co-authored-by: Tyler Helmuth <12352919+TylerHelmuth@users.noreply.github.com>
**Description:** Updates the AzureEventsHubReceiver to use the new azure resource logs translator. Includes the following changes: - Add config option to enable the new behaviour, default is off so requires users to opt-in - Add interface to allow switching over the previous and new translator logic - Update receiver to use new config option to return the appropriate translator - Update README with new configuration option Follow-up PR to adding the translator: - #34830 **Link to tracking Issue:** N/A **Testing:** Includes unit test to verify configuration defaults and changes. **Documentation:** N/A --------- Co-authored-by: Alex Boten <223565+codeboten@users.noreply.github.com>
…-telemetry#35357) **Description:** Updates the AzureEventsHubReceiver to use the new azure resource logs translator. Includes the following changes: - Add config option to enable the new behaviour, default is off so requires users to opt-in - Add interface to allow switching over the previous and new translator logic - Update receiver to use new config option to return the appropriate translator - Update README with new configuration option Follow-up PR to adding the translator: - open-telemetry#34830 **Link to tracking Issue:** N/A **Testing:** Includes unit test to verify configuration defaults and changes. **Documentation:** N/A --------- Co-authored-by: Alex Boten <223565+codeboten@users.noreply.github.com>
Description:
This PR adds a new Azure Resource Logs translator that can be used to convert Azure events into resource logs events using Semantic conventions defined here here.
This supersedes following draft PR by updating it to have the latest semconv:
Note: A follow-up PR will update the Azure receiver to use the new translator.
Testing:
Includes unit tests to verify expected behaviours and data structures.
Documentation:
cc @markrendle @lmolkova @TylerHelmuth