Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update AzureEventsHubReceiver with new resource logs translator #35357

Conversation

MikeGoldsmith
Copy link
Member

@MikeGoldsmith MikeGoldsmith commented Sep 23, 2024

Description:

Updates the AzureEventsHubReceiver to use the new azure resource logs translator.

Includes the following changes:

  • Add config option to enable the new behaviour, default is off so requires users to opt-in
  • Add interface to allow switching over the previous and new translator logic
  • Update receiver to use new config option to return the appropriate translator
  • Update README with new configuration option

Follow-up PR to adding the translator:

Link to tracking Issue:
N/A

Testing:
Includes unit test to verify configuration defaults and changes.

Documentation:
N/A

Copy link
Contributor

@cparkins cparkins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

Copy link
Contributor

github-actions bot commented Oct 8, 2024

This PR was marked stale due to lack of activity. It will be closed in 14 days.

@github-actions github-actions bot added the Stale label Oct 8, 2024
…tor-contrib into mike/azure-events-receiver-translator

# Conflicts:
#	cmd/otelcontribcol/go.mod
#	receiver/azureeventhubreceiver/go.mod
@MikeGoldsmith
Copy link
Member Author

Updated branch with latest on main.

Please can we get more of @open-telemetry/collector-contrib-approvers to take a look?

@github-actions github-actions bot removed the Stale label Oct 10, 2024
Copy link
Contributor

@codeboten codeboten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@andrzej-stencel andrzej-stencel merged commit 0986213 into open-telemetry:main Oct 16, 2024
158 checks passed
@github-actions github-actions bot added this to the next release milestone Oct 16, 2024
@MikeGoldsmith MikeGoldsmith deleted the mike/azure-events-receiver-translator branch October 18, 2024 14:29
sbylica-splunk pushed a commit to sbylica-splunk/opentelemetry-collector-contrib that referenced this pull request Dec 17, 2024
…-telemetry#35357)

**Description:**

Updates the AzureEventsHubReceiver to use the new azure resource logs
translator.

Includes the following changes:
- Add config option to enable the new behaviour, default is off so
requires users to opt-in
- Add interface to allow switching over the previous and new translator
logic
- Update receiver to use new config option to return the appropriate
translator
- Update README with new configuration option

Follow-up PR to adding the translator:
- open-telemetry#34830 

**Link to tracking Issue:**
N/A

**Testing:**
Includes unit test to verify configuration defaults and changes.

**Documentation:**
N/A

---------

Co-authored-by: Alex Boten <223565+codeboten@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants