Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[chore] [cmd/opampsupervisor]: Fix failing supervisor test #35551

Merged

Conversation

dpaasman00
Copy link
Contributor

Description:

Fixes a failing test that won't work on windows because chmod doesn't affect windows file perms.

Link to tracking Issue:

Testing:

Documentation:

@dpaasman00 dpaasman00 force-pushed the fix-failing-new-supervisor-test branch from 727e4a2 to 12a8308 Compare October 2, 2024 14:09
@dpaasman00 dpaasman00 changed the title [chore] [cmd/opampsupervisor]: Fix failing supervisor test [cmd/opampsupervisor]: Fix failing supervisor test Oct 2, 2024
@dpaasman00 dpaasman00 changed the title [cmd/opampsupervisor]: Fix failing supervisor test [chore] [cmd/opampsupervisor]: Fix failing supervisor test Oct 2, 2024
@dpaasman00 dpaasman00 marked this pull request as ready for review October 2, 2024 14:20
@dpaasman00 dpaasman00 requested a review from a team as a code owner October 2, 2024 14:20
@djaglowski djaglowski added the Run Windows Enable running windows test on a PR label Oct 2, 2024
Copy link
Contributor

@jackgopack4 jackgopack4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

Copy link
Contributor

@evan-bradley evan-bradley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@evan-bradley evan-bradley merged commit b084ef1 into open-telemetry:main Oct 2, 2024
181 checks passed
@github-actions github-actions bot added this to the next release milestone Oct 2, 2024
@dpaasman00 dpaasman00 deleted the fix-failing-new-supervisor-test branch October 2, 2024 19:13
jriguera pushed a commit to springernature/opentelemetry-collector-contrib that referenced this pull request Oct 4, 2024
…metry#35551)

**Description:** <Describe what has changed.>
<!--Ex. Fixing a bug - Describe the bug and how this fixes the issue.
Ex. Adding a feature - Explain what this achieves.-->
Fixes a failing test that won't work on windows because chmod doesn't
affect windows file perms.

**Link to tracking Issue:** <Issue number if applicable>

**Testing:** <Describe what testing was performed and which tests were
added.>

**Documentation:** <Describe the documentation added.>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cmd/opampsupervisor Run Windows Enable running windows test on a PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants