Skip to content

Commit

Permalink
[chore] [cmd/opampsupervisor]: Fix failing supervisor test (open-tele…
Browse files Browse the repository at this point in the history
…metry#35551)

**Description:** <Describe what has changed.>
<!--Ex. Fixing a bug - Describe the bug and how this fixes the issue.
Ex. Adding a feature - Explain what this achieves.-->
Fixes a failing test that won't work on windows because chmod doesn't
affect windows file perms.

**Link to tracking Issue:** <Issue number if applicable>

**Testing:** <Describe what testing was performed and which tests were
added.>

**Documentation:** <Describe the documentation added.>
  • Loading branch information
dpaasman00 authored and jriguera committed Oct 4, 2024
1 parent 2d7836a commit 906fe1e
Showing 1 changed file with 4 additions and 0 deletions.
4 changes: 4 additions & 0 deletions cmd/opampsupervisor/supervisor/supervisor_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,7 @@ import (
"net"
"os"
"path/filepath"
"runtime"
"sync/atomic"
"testing"
"time"
Expand Down Expand Up @@ -80,6 +81,9 @@ func Test_NewSupervisor(t *testing.T) {
}

func Test_NewSupervisorFailedStorageCreation(t *testing.T) {
if runtime.GOOS == "windows" {
t.Skip("Skipping test on Windows because chmod doesn't affect permissions on Windows, so this test won't work.")
}
cfg := setupSupervisorConfig(t)

dir := filepath.Dir(cfg.Storage.Directory)
Expand Down

0 comments on commit 906fe1e

Please sign in to comment.