review units for metadata.yaml telemetry

[codeboten]

Many metrics generated by the collector (via mdatagen) and configured via metadata.yaml have units set to dimensionless (or "1"). We should review these to ensure they adhere to semantic conventions

List of metrics to review in this repo:

• Review metadata.yaml units for internal telemetry: cmd/mdatagen/testdata #10654
• Review metadata.yaml units for internal telemetry: cmd/mdatagen/internal/samplereceiver #10653
• Review metadata.yaml units for internal telemetry: processor/processorhelper #10651
• Review metadata.yaml units for internal telemetry: processor/batchprocessor #10652
• Review metadata.yaml units for internal telemetry: receiver/receiverhelper #10650
• Review metadata.yaml units for internal telemetry: receiver/scraperhelper #10649
• Review metadata.yaml units for internal telemetry: exporter/exporterhelper #10648

An example PR for one: #10647

[crobert-1]

For reference, here's the current full list of references to unit: "1" in core:

List

cmd/mdatagen/testdata/no_type_attr.yaml:    unit: "1"
cmd/mdatagen/testdata/unused_attribute.yaml:    unit: "1"
cmd/mdatagen/testdata/invalid_type_attr.yaml:    unit: "1"
cmd/mdatagen/internal/samplereceiver/metadata.yaml:    unit: "1"
cmd/mdatagen/internal/samplereceiver/metadata.yaml:      unit: "1"
cmd/mdatagen/internal/samplereceiver/metadata.yaml:      unit: "1"
processor/processorhelper/metadata.yaml:      unit: "1"
processor/processorhelper/metadata.yaml:      unit: "1"
processor/processorhelper/metadata.yaml:      unit: "1"
processor/processorhelper/metadata.yaml:      unit: "1"
processor/processorhelper/metadata.yaml:      unit: "1"
processor/processorhelper/metadata.yaml:      unit: "1"
processor/processorhelper/metadata.yaml:      unit: "1"
processor/processorhelper/metadata.yaml:      unit: "1"
processor/processorhelper/metadata.yaml:      unit: "1"
processor/processorhelper/metadata.yaml:      unit: "1"
processor/processorhelper/metadata.yaml:      unit: "1"
processor/processorhelper/metadata.yaml:      unit: "1"
processor/batchprocessor/metadata.yaml:      unit: "1"
processor/batchprocessor/metadata.yaml:      unit: "1"
processor/batchprocessor/metadata.yaml:      unit: "1"
processor/batchprocessor/metadata.yaml:      unit: "1"
receiver/receiverhelper/metadata.yaml:      unit: "1"
receiver/receiverhelper/metadata.yaml:      unit: "1"
receiver/receiverhelper/metadata.yaml:      unit: "1"
receiver/receiverhelper/metadata.yaml:      unit: "1"
receiver/receiverhelper/metadata.yaml:      unit: "1"
receiver/receiverhelper/metadata.yaml:      unit: "1"
receiver/scraperhelper/metadata.yaml:      unit: "1"
receiver/scraperhelper/metadata.yaml:      unit: "1"
exporter/exporterhelper/metadata.yaml:      unit: "1"
exporter/exporterhelper/metadata.yaml:      unit: "1"
exporter/exporterhelper/metadata.yaml:      unit: "1"
exporter/exporterhelper/metadata.yaml:      unit: "1"
exporter/exporterhelper/metadata.yaml:      unit: "1"
exporter/exporterhelper/metadata.yaml:      unit: "1"
exporter/exporterhelper/metadata.yaml:      unit: "1"
exporter/exporterhelper/metadata.yaml:      unit: "1"
exporter/exporterhelper/metadata.yaml:      unit: "1"
exporter/exporterhelper/metadata.yaml:      unit: "1"
exporter/exporterhelper/metadata.yaml:      unit: "1"

In terms of reviewing each metric, here's the component list that we can review to track this issue's completion:

• cmd/mdatagen/testdata
• cmd/mdatagen/internal/samplereceiver
• processor/processorhelper
• processor/batchprocessor
• receiver/receiverhelper
• receiver/scraperhelper
• exporter/exporterhelper

[codeboten]

Thanks @crobert-1, i updated the description to include the checklist and opened an issue for each one. This should make it each to parallelize the work

[codeboten]

This is done now