Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[processorhelper] update units for metrics #10647

Merged

Conversation

codeboten
Copy link
Contributor

@codeboten codeboten commented Jul 17, 2024

This updates units for processhelper's internal telemetry.

Related #10556

Fixes #10651

For this PR i updated metadata.yaml and ran make gogenerate, then make -C processor test

This updates units for processhelper's internal telemetry.

Signed-off-by: Alex Boten <223565+codeboten@users.noreply.github.com>
@codeboten codeboten requested review from a team and djaglowski July 17, 2024 22:34
Copy link

codecov bot commented Jul 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.33%. Comparing base (43ed618) to head (5e1c134).
Report is 6 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #10647      +/-   ##
==========================================
+ Coverage   92.32%   92.33%   +0.01%     
==========================================
  Files         397      403       +6     
  Lines       18701    18733      +32     
==========================================
+ Hits        17265    17297      +32     
  Misses       1076     1076              
  Partials      360      360              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@crobert-1 crobert-1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Out of ignorance, what kind of change do we consider changing metric units? Do we need a changelog entry for this?

@codeboten
Copy link
Contributor Author

Out of ignorance, what kind of change do we consider changing metric units? Do we need a changelog entry for this?

I believe we should have a changelog for this, will add one shortly

Signed-off-by: Alex Boten <223565+codeboten@users.noreply.github.com>
@codeboten
Copy link
Contributor Author

Changelog added, PTAL @crobert-1

@codeboten codeboten merged commit 9ef6356 into open-telemetry:main Jul 22, 2024
50 checks passed
@codeboten codeboten deleted the codeboten/update-units-processorhelper branch July 22, 2024 16:55
@github-actions github-actions bot added this to the next release milestone Jul 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Review metadata.yaml units for internal telemetry: processor/processorhelper
3 participants